[GraphTrainer] Fix test_deterministic: update model hash and calling update_from_config#3605
Open
wwwjn wants to merge 1 commit into
Open
[GraphTrainer] Fix test_deterministic: update model hash and calling update_from_config#3605wwwjn wants to merge 1 commit into
wwwjn wants to merge 1 commit into
Conversation
wwwjn
requested review from
IvanKobzarev,
SherlockNoMad,
aditvenk,
sanketpurandare,
tianyu-l and
xmfan
as code owners
meta-cla
Bot
added
the
CLA Signed
wwwjn
changed the title
| assert_expected_inline( | ||
| model_hash, | ||
| """d8c4495bc41d103e3864433002d31be0823567938729396c44eb2f2782a47a23""", | ||
| """4cf2bed8281dfcdf4a5e5ced666ccd65681fab5fcaf404e14e91b583fe21bd4c""", |
Contributor
There was a problem hiding this comment.
thanks for the fix, you need to rebase over main. and unskip these test_eager_self_deterministic tests.
Contributor
Author
There was a problem hiding this comment.
Thanks you, let me fix that and make sure the CI passed before landing
SherlockNoMad
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torchtitan/experiments/graph_trainer/tests/test_bitwise_deterministic.py::TestLlama3BitwiseDeterministic::test_eager_self_deterministic - AssertionError: Mismatch between actual and expect strings: