[graph_trainer] Replace stable_topological_sort with _move_overlap_nodes in fsdp_passes#3607
Draft
SherlockNoMad wants to merge 1 commit into
Draft
[graph_trainer] Replace stable_topological_sort with _move_overlap_nodes in fsdp_passes#3607SherlockNoMad wants to merge 1 commit into
SherlockNoMad wants to merge 1 commit into
Conversation
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Replace the two
_stable_topological_sortcalls inJointManualOverlapSchedulerwith
_move_overlap_nodesfrom upstream pytorch. This surgically moves onlythe AG/RS chains instead of re-sorting the entire graph, reducing node
displacement from ~97% to ~5% and making the pass composable with downstream
graph passes.
_manual_bucket_collectives: remove the no-op_stable_topological_sort(graph, {})call after bucketing — the graph is already valid after
manual_bucket_collectives._manual_reorder_graph: replace_stable_topological_sort(graph, overlap_deps)with
_move_overlap_nodes(graph, overlap_deps, bucketed_node_types).Depends on pytorch PR #184711.
Authored by Claude.
(cherry picked from commit 504dc71)