[Checkpointer] Remove the dependencies on PyTorch distributed state_dict APIs#3623
Open
fegin wants to merge 4 commits into
Open
[Checkpointer] Remove the dependencies on PyTorch distributed state_dict APIs#3623fegin wants to merge 4 commits into
fegin wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
tianyu-l
reviewed
Jun 11, 2026
Contributor
There was a problem hiding this comment.
Now that we are not using DCP APIs, could you prompt claude to add the _save_to_state_dict / ``_load_from_state_dict` hooks and see if it just solves #3569
| # Per-optimizer regex patterns (aligned with self.schedulers), used as lr | ||
| # metric labels. Sourced from the container so patterns stay off the | ||
| # optimizer param groups and out of the saved state dict. | ||
| self._param_group_patterns = optimizers._param_group_patterns |
Contributor
There was a problem hiding this comment.
can we not add this simply for logging purpose? I think it's available in optimizers.config?
| # the list of patterns for that optimizer's param groups. Kept here, off the | ||
| # optimizer param groups, so they feed logging and lr metrics without leaking | ||
| # into the saved optimizer state dict. | ||
| _param_group_patterns: list[list[str]] |
Contributor
There was a problem hiding this comment.
It seems it's also only for logging. Let's remove for now, or we can move the logging into _build_param_groups where we still have access to patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Same as #2441 but with new implementation to be compatiblewith the latest OptimizerContainer
Verification: