Prepared for latest RSR data files - with new modis platform names#281
Prepared for latest RSR data files - with new modis platform names#281adybbroe merged 4 commits intopytroll:mainfrom
Conversation
…s (Aqua and Terra) Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 25 25
Lines 2673 2673
=======================================
Hits 2437 2437
Misses 236 236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djhoese
left a comment
There was a problem hiding this comment.
It is possible to have aliases in the various dictionaries in pyspectral so things still work? Or was that already the case? If it was already the case, do the dictionaries need to be updated to point from the new-old name to the old-new name? Otherwise looks good to me.
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
I guess you could do that quite easily, but we don't have a platform name translation dictionary. I updated the |
Platform names are Aqua and Terra, and not EOS-Aqua and EOS-Terra.
pytest pyspectralflake8 pyspectralAUTHORS.mdif not there already