Skip to content

Prepared for latest RSR data files - with new modis platform names#281

Merged
adybbroe merged 4 commits intopytroll:mainfrom
adybbroe:changed-modis-satellite-names
Apr 1, 2026
Merged

Prepared for latest RSR data files - with new modis platform names#281
adybbroe merged 4 commits intopytroll:mainfrom
adybbroe:changed-modis-satellite-names

Conversation

@adybbroe
Copy link
Copy Markdown
Collaborator

@adybbroe adybbroe commented Mar 30, 2026

Platform names are Aqua and Terra, and not EOS-Aqua and EOS-Terra.

…s (Aqua and Terra)

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe requested a review from djhoese March 30, 2026 17:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.17%. Comparing base (cb6834b) to head (7a61fdf).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          25       25           
  Lines        2673     2673           
=======================================
  Hits         2437     2437           
  Misses        236      236           
Flag Coverage Δ
unittests 91.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to have aliases in the various dictionaries in pyspectral so things still work? Or was that already the case? If it was already the case, do the dictionaries need to be updated to point from the new-old name to the old-new name? Otherwise looks good to me.

Adam.Dybbroe added 3 commits April 1, 2026 19:39
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe
Copy link
Copy Markdown
Collaborator Author

adybbroe commented Apr 1, 2026

It is possible to have aliases in the various dictionaries in pyspectral so things still work? Or was that already the case? If it was already the case, do the dictionaries need to be updated to point from the new-old name to the old-new name? Otherwise looks good to me.

I guess you could do that quite easily, but we don't have a platform name translation dictionary. I updated the INSTRUMENT dictionary to include Aqua and Terra to be consistent but that doesn't have an effect on this. The rsr filename is created from the sensor and platform_name as provided. As this is not supposed to happen often I didn't spend more time here. Updated the RSR tar file once more, now also with sensor name in the attributes. And it seems I actually missed including the 2 new RSR files in the new zenodo release. This is fixed now.

@adybbroe adybbroe merged commit 4b86060 into pytroll:main Apr 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MODIS platform name not compatible with satpy

2 participants