Remove usage of unittest testcase#242
Merged
mraspaud merged 5 commits intopytroll:mainfrom Oct 20, 2025
Merged
Conversation
mraspaud
reviewed
Oct 20, 2025
Member
mraspaud
left a comment
There was a problem hiding this comment.
Thanks a lot for taking this up, and it looks good so far...
Member
Author
|
The problem was simply that I didn't notice one tear-down method and renaming it solved the race conditions. At least it did locally... |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 94.75% 94.52% -0.23%
==========================================
Files 15 15
Lines 3373 3379 +6
==========================================
- Hits 3196 3194 -2
- Misses 177 185 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got annoyed by a directory named
"örülök, hogy megismerhetem"being created in the repository directory. While hunting why it wasn't removed automatically, I ended up removing the usage ofunittest.TestCasefrom the tests. Also use of single quotes is replaced with double quotes.flake8 trollflow2AUTHORS.mdif not there already