added configurable scp put timeout. added tests#121
added configurable scp put timeout. added tests#121TAlonglong wants to merge 5 commits intopytroll:mainfrom
Conversation
…long/trollmoves into issue120-scpclient-timeout-config
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 76.57% 76.74% +0.17%
==========================================
Files 18 18
Lines 3893 3922 +29
==========================================
+ Hits 2981 3010 +29
Misses 912 912
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure what the stickler issue is about. ELLIPSIS_MARKER is not used. Was it used in the past and not used anymore? If you have time @pnuu |
pnuu
left a comment
pnuu
left a comment
There was a problem hiding this comment.
In principle LGTM, but couple of requests inline.
|
|
||
| """Movers for the move_it scripts.""" | ||
|
|
||
| from doctest import ELLIPSIS_MARKER |
There was a problem hiding this comment.
I don't see this in main at all, so don't know where it's coming from. Should be safe to remove.
There was a problem hiding this comment.
Oh, actually, it's coming from this PR since it shows up in the diff.
|
|
||
| @patch('trollmoves.movers.SSHClient', autospec=True) | ||
| @patch('trollmoves.movers.SCPClient', autospec=True) | ||
| def test_scp_copy_custom_timeout(self, mock_scp_client, mock_sshclient): |
There was a problem hiding this comment.
The timeout isn't tested in this test, so either adjust the name or test the timeout.
2 participants
Added configurable scpclient_timeout_seconds attribute to the scpclient put.