Skip to content

ci: corrected content pushed to python-release - #7

Merged
susek555 merged 1 commit into
mainfrom
3-improve-ci
Dec 19, 2025
Merged

ci: corrected content pushed to python-release#7
susek555 merged 1 commit into
mainfrom
3-improve-ci

Conversation

@susek555

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the content being pushed to the python-release branch by improving how binary artifacts are handled and copied to the release directory.

Key Changes:

  • Modified artifact download to use an intermediate temporary directory (/tmp/real-binary) instead of directly to the target location
  • Reorganized the binary copying logic with explicit directory creation and file copying using find
  • Changed the final copy command from cp -r python_release/* to cp -a python_release/. to preserve all files including hidden ones

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


# clean up unneeded files
rm -rf python_release/tests
find python_release -type d -name "__pycache__" -exec rm -rf {} +

Copilot AI Dec 19, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The find command with -exec rm -rf {} + can fail when removing nested pycache directories because it may attempt to access a parent directory after its child has already been deleted. This can cause the command to exit with an error. Consider using -prune flag or pipe to xargs with proper handling, or use -delete flag instead. For example: find python_release -type d -name "__pycache__" -prune -exec rm -rf {} \; or add || true to ignore errors if that's acceptable.

Suggested change
find python_release -type d -name "__pycache__" -exec rm -rf {} +
find python_release -type d -name "__pycache__" -prune -exec rm -rf {} \;

Copilot uses AI. Check for mistakes.
@susek555
susek555 merged commit af6b054 into main Dec 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants