ci: corrected content pushed to python-release - #7
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the content being pushed to the python-release branch by improving how binary artifacts are handled and copied to the release directory.
Key Changes:
- Modified artifact download to use an intermediate temporary directory (
/tmp/real-binary) instead of directly to the target location - Reorganized the binary copying logic with explicit directory creation and file copying using
find - Changed the final copy command from
cp -r python_release/*tocp -a python_release/.to preserve all files including hidden ones
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # clean up unneeded files | ||
| rm -rf python_release/tests | ||
| find python_release -type d -name "__pycache__" -exec rm -rf {} + |
There was a problem hiding this comment.
The find command with -exec rm -rf {} + can fail when removing nested pycache directories because it may attempt to access a parent directory after its child has already been deleted. This can cause the command to exit with an error. Consider using -prune flag or pipe to xargs with proper handling, or use -delete flag instead. For example: find python_release -type d -name "__pycache__" -prune -exec rm -rf {} \; or add || true to ignore errors if that's acceptable.
| find python_release -type d -name "__pycache__" -exec rm -rf {} + | |
| find python_release -type d -name "__pycache__" -prune -exec rm -rf {} \; |
No description provided.