Release/2.0.0 - #65
Open
trifonovmixail wants to merge 206 commits into
Open
trifonovmixail wants to merge 206 commits into
trifonovmixail wants to merge 206 commits into
Conversation
The pipeline cell gains the AFM_DOCKER_FILE_ROOTS payload: the CODEMANIFEST declares FileRoot, collect_file_roots, and encode_file_roots (file_roots.py) and layers the encoded roots into the run-form env-file — an explicit user -e entry still wins. The afm practice documents the base64 JSON schema and the roots scope, the Dockerfile carries the static image default (project root only), and the pipeline usage file explains exposing extra directories via home.docker.run volume tokens. The run/info container modules take blank-line-only formatting.
…the pipeline facade
…ome.docker.run tokens
… no-env-file test)
- docs: document AFM_DOCKER_FILE_ROOTS (runtime.md) and the docker.run file-manager side effect (home.md) — user-facing behavior shipped with zero human documentation - tests: pin the launcher-composed roots winning over home.env / config.pipeline.env keys (the payload must mirror actual mounts) - tests: cover the ro,z comma-list mode segment and the trailing dangling -v flag branch
… generator sub-cells
Refactor the onboarding architecture: introduce four sub-cells
(questions, survey, participation, generator) with their own
CODEMANIFESTs and usage files, and rewire the onboarding facade
manifest to import from them instead of declaring everything inline.
- add goga/onboarding/{questions,survey,participation,generator}
cells with .usages (question-records, survey-run,
session-participation, tool-contexts, artifact-generation)
- add hooks usage per-tool-delivery and version usage minor-line;
update hooks, hooks/catalog, version and commands/init manifests
- record the staged-guarantees-over-fire-and-forget ADR in
.goga/memory/architecture.md
- bump AFM_VERSION to 1.0.3 in the Dockerfile
…nd generator cell facade
… delete the old answer modules
…olParticipation wiring
- add goga/usages/hooks zone cell owning the four usages notification moments (CODEMANIFEST + usages-moments usage) - add registering-hooks usage for tool packages subscribing to the usages events; extend the usages command imports and annotations - extend the usages sync and status CODEMANIFESTs with UsagesHooks delivery: start and completion moments on every return path, per-dep outcome and drift facts, notification-only guarantees - register the four soft usages actions in the hooks catalog - document the usages hook events in the feature docs - record the add-hooks-to-usages history (prd, task, arch, adr, design, plan)
- Pin the success fact on populated fact sets: an all-synced sync run asserts success is True with non-empty deps, and the status error-dep run asserts success is False - Parametrize the failing-hook tests over both addresses of each operation (started and completed), adding the missing status-side coverage - Add the sync partial-crash test: the crashed completion carries the outcomes recorded before the break-off - Add KeyboardInterrupt tests: a BaseException completes nothing and propagates, matching the platform's catch policy - Single-source the all-addresses moment recorder: the recorder fixture and _of projection move to tests/usages/conftest.py, replacing the three byte-identical module-local copies - Drop the stale 'until the facade lands' rationale from the zone test module docstrings (the facade landed in this branch) - Document the four usages moments in README's register_hooks enumeration, hooks/index.md, tools/hooks.md, the per-domain facade list of hooks/api.md, and the usages/api.md child-cell enumeration with a hooks-zone section
- Replace the GOGA_WORKFLOW_NAME / GOGA_WORKFLOW_DISABLED / GOGA_SKIP_STAGES env-file channel with -w/--workflow, --no-workflow, and repeatable -s/--skip flags on the in-container argv for both the run and card forms; run coordination and describe_pipeline take the workflow decision and skip names as explicit parameters instead of reading the environment, and the card accepts skip - Delete the goga/agents/credentials cell, its facade re-export, and its tests: credential mounts become user-owned per the docker-auth-mounts cook - Update the CODEMANIFEST contracts and usages of goga/agents, goga/commands/build, goga/commands/pipeline, goga/pipeline, and goga/pipeline/compiler accordingly - Record the pipeline-host-to-docker-values topic history: ADR, arch, task, design, and plan
The groundwork commit removed the goga/agents/credentials cell and its facade re-export but left both launchers importing the deleted name, so any `python -m goga` invocation died at package import and the pipeline build stage could not start. Apply the credential-removal part of plan Tasks 4/5: delete the imports, the credential mount loops, the comment tails, and the docstring sentence. The remaining plan tasks stay with the build stage.
The code-side removal (broken resolve_credential_mounts import, the credential mount loop, its comment tail, and the docstring sentences) already landed in 9f74f7a; this change-set finishes Task 4 on the test side: - delete tests/commands/build/test_build_credential_mount_integration.py (it tests the removed feature) - drop the nine stale resolve_credential_mounts monkeypatches from tests/commands/build/test_build.py and test_build_runtime_isolation_integration.py (AttributeError against the deleted symbol since 9f74f7a) - add test_no_credential_mounts_in_build_launcher: params['v'] is exactly [project:/workspace, runtime:/workspace/.ralphex], with a decoy ~/.codex/auth.json under the isolated home so a reintroduced credential loop would fail the exact-two assertion - realign the stale HOME-isolation comment in test_build_proxy_hosts_update.py pytest tests/commands/build -x: 70 passed; ruff check goga/: clean. tests/commands/test_build.py and tests/integration/test_runtime_isolation.py still assert the removed behavior by design — they are Task 8's full-suite migration scope.
- reject leading-dash -w/-s values host-side (click swallowed them; argparse failed only in-container after launch) - absolute-path example in docker-auth-mounts cook (~ is not expanded) - drop deleted goga/agents/credentials from mkdocs traceability map - tests: no_workflow+skip composition, launcher-argv replay through real parser, CLI skip error paths, empty skip name pinned - docs: remove automatic-credential-forwarding claims (README, runtime, build, automation, getting-started, index); argv-channel updates (pipelines/cli, workflows, api) - fix pre-existing ruff SIM117/RUF043 in test_describe_pipeline
- commands/pipeline: document the step 2.5 leading-dash argv rejection in the pipeline Algorithm (added with the argv channel, was missing from the manifest) and the containment guard of the auto-match workflow-log decision in run_pipeline_container step 9 - commands/build: declare the full build Click callback signature (ctx, dry_run, timeouts, iterations, base_ref, extra_env, ...) per the project convention used by the upgrade/install/pipeline commands, with param docs for the ten previously-undocumented parameters
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.