fix(cli): align table columns by display width - #1608
Chase J (chajac) wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. WalkthroughThe CLI adds Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Unblocks: 5 PRs Suggested reviewers: Merge Risk: ⚪ Minimal · up to The table renderer now uses display-column width for Unicode and ANSI-styled values, with focused helper and rendering coverage. No merge-blocking issue remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
5d22b52 to
e746617
Compare
Overview of Changes
Tables can misalign when text contains wide characters or combining marks. This change measures terminal display width when it pads columns. The existing
fast-string-widthpackage supplies the measurements.Base:
main.Testing
Naming, lint, format, type, unused-code, and build checks passed. The full test suite passed: 2,485 tests, no failures.
bash scripts/check-naming.sh bun run typecheck bun run lint --max-warnings 0 bun run format:check bun run knip bun run test bun run buildTests cover ASCII text, wide characters, emoji, combining marks, and terminal color codes.
Checklist