Skip to content

Add waitForReady support to BasePageObject - #27

Open
Zachary Artman (zacharyartman) wants to merge 2 commits into
mainfrom
age-4706-add-waitforready-support-to-basepageobject
Open

Zachary Artman (zacharyartman) wants to merge 2 commits into
mainfrom
age-4706-add-waitforready-support-to-basepageobject

Conversation

@zacharyartman

@zacharyartman Zachary Artman (zacharyartman) commented Sep 4, 2026

Copy link
Copy Markdown

Overview of Changes

  • BasePageObject gains a protected waitForReady() hook, a no-op by default. createFromPage and both forms of create now await it before returning the new page object, so a navigation method like openContractors returns a page that is ready to use. Pass { waitForReady: false } to either to skip the wait.

Checklist

  • Changes follow the code style of this project
  • Self-review completed
  • Tests added/updated (or not applicable)
  • No breaking changes (or described below)

Breaking Change: Callers that use createFromPage's result without awaiting must add an await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant