feat: Bond, Skills/XP, Reincarnation, dna.md unpacking#39
Open
prakashUXtech wants to merge 1 commit intomainfrom
Open
feat: Bond, Skills/XP, Reincarnation, dna.md unpacking#39prakashUXtech wants to merge 1 commit intomainfrom
prakashUXtech wants to merge 1 commit intomainfrom
Conversation
Rebased soul-primitives onto current main (4da5a96), preserving all main's features (StrEnum, cognitive engine, psychology types, self-model, general_events, error handling, CI pipeline) while adding: - Bond model: human-soul relationship tracking with strengthen/weaken - Skill & SkillRegistry: XP progression system with level cap at 10 - Soul.reincarnate(): lifecycle rebirth preserving memories, DNA, lineage - Identity: bond, incarnation, previous_lives fields - unpack.py: reads dna.md from .soul archives - 43 new tests (bond, skills, reincarnation, e2e lifecycle) Review fixes applied: - Uses relative import for Bond in types.py (from .bond import Bond) - Added decision comment in reincarnate() for born reset - Passes core_values to MemoryManager.from_dict() in reincarnate() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Security scan: review neededPotentially dangerous code patterns detected in changed files. A maintainer should verify these are intentional and safe.### src/soul_protocol/soul.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased version of #34 onto current main (4da5a96). The old branch diverged from a very early commit and would have reverted StrEnum, cognitive engine exports, self-model/general_events extraction, error handling, and CI pipeline changes.
This PR adds soul primitives on top of the full main codebase:
bond.py) — Human-Soul relationship tracking with strengthen/weaken mechanics, 0-100 bond strength, interaction counterskills.py) — Skill with level progression (1-10), exponential XP scaling, SkillRegistry collectionsoul.py) —Soul.reincarnate()classmethod creates a new soul from existing essence, preserves memories/personality/bond, tracks incarnation count and previous lives viaIdentity.previous_livestypes.py) — Addedbond: Bond,incarnation: int,previous_lives: list[str]to Identityunpack.py) — Now readsdna.mdfrom .soul archives intomemory_data["dna_md"]__init__.py) — AddedBond,Skill,SkillRegistryto package APIReview fixes from #34 applied:
from .bond import Bond)core_valuestoMemoryManager.from_dict()in reincarnate()Test plan