Merged
Conversation
JojiiOfficial
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several issues in the request building:
PrefetchQueryBuilder.query()returns a new builder, but the result was thrown away. Now the builder is properly chained:.query().params().limit().build().PrefetchQueryis now added to the request via.prefetch(vec![prefetch]).hnsw_ef- Both occurrences ofself.args.hnsw_ef_constructin the search path were changed toself.args.search_hnsw_ef(the parameter meant for search, not index construction).search_paramsoverwriting prefetch params - The prefetch branch now sets its own params on the prefetch query, andsearch_paramsis applied to the top-level request in both branches without conflict.Also improving the Rust client to avoid this issue completely in the future qdrant/rust-client#276