Handle benchmark errors gracefully instead of panicking#118
Open
qdrant-cloud-bot wants to merge 1 commit intodevfrom
Open
Handle benchmark errors gracefully instead of panicking#118qdrant-cloud-bot wants to merge 1 commit intodevfrom
qdrant-cloud-bot wants to merge 1 commit intodevfrom
Conversation
Replace `.unwrap()` on `run_benchmark()` result with proper error handling. Previously, when all upsert retries were exhausted (e.g. during chaos testing node kills), the error would propagate to main() and hit `.unwrap()`, producing an ugly panic with stack trace instead of a clean error message and exit code. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.unwrap()onrun_benchmark()result inmain()with proper error handling that prints the error and exits with code 1main()and hit.unwrap(), producing an ugly panic with stack trace instead of a clean exitContext
Observed on
qdrant-chaos-testing-three(2026-03-25 17:00–19:00 UTC): the combination ofkill-random-nodecron (~every 10 min), resharding, and rolling updates caused upsert timeouts. After exhausting all 5 retries, bfb panicked with:Test plan
cargo checkpassesMade with Cursor