Skip to content

snp quic#20

Open
turuslan wants to merge 52 commits into
masterfrom
snp/quic
Open

snp quic#20
turuslan wants to merge 52 commits into
masterfrom
snp/quic

Conversation

@turuslan

@turuslan turuslan commented Feb 11, 2025

Copy link
Copy Markdown
Contributor
  • ./example_chat server and ./example_chat 1, ./example_chat 2, ./example_chat 3 clients.
  • ConnectionsConfig
    • GenesisHash
    • ed25519::KeyPair
    • optional<Port> listen_port
  • Connections
    • Connections::connect(Address)
    • Connections::serve(ProtocolId, ServeProtocol)
  • ConnectionsController
    • ConnectionsController::onOpen(Key)
    • ConnectionsController::onClose(Key)
  • Connection
    • Connection::open(ProtocolId)
  • Stream
    • Stream::read(Bytes &message, MessageSize max)
    • Stream::readFin()
    • Stream::write(BytesIn message)
    • Stream::writeFin()
  • co_await
  • thread safe

@turuslan
snp quic
1b02d30 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from iceseer and xDimon February 11, 2025 05:18
@turuslan
ci
f67cf4e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
ci
ed8eb71 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
snp quic + rebase
f7cf132 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
merge rebase
8444b77 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
xDimon requested changes Feb 17, 2025
View reviewed changes
Comment thread CMakeLists.txt
Comment thread src/TODO_qtils/macro/forward.hpp Outdated
Comment thread src/TODO_qtils/macro/make_shared.hpp Outdated
Comment thread src/TODO_qtils/macro/move.hpp Outdated
Comment thread src/TODO_qtils/macro/weak.hpp Outdated
Comment thread src/snp/connections/lsquic/engine.cpp
reading_.remote_endpoint.data(),
&len);
if (n == -1) {
if (errno == EAGAIN or errno == EWOULDBLOCK) {

@xDimon xDimon Feb 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other errors should be handled too (i.e. shutdown connection)

@turuslan turuslan Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing to write one packet may fail some connection/stream.
Failing to write/read packets may fail some connection/stream by timeout.

I don't know why can reading opened udp socket fail, or what to to when it fails.

@xDimon xDimon Feb 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. case of transport (aka network interface, eth0, wifi0, etc.) is closed/ubreacheble/off

@turuslan turuslan Mar 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added error logging

Comment thread src/snp/connections/lsquic/engine.cpp Outdated
Comment thread src/snp/connections/lsquic/engine.cpp Outdated
Comment thread src/snp/connections/lsquic/engine.cpp Outdated
Comment thread src/snp/connections/lsquic/engine.cpp Outdated
@turuslan
forward
bffc90b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
make_shared
e499d39 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
move
95699a2 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
weak
89f987b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
set coro thread
0c9f159 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
coro yield
f742c39 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
enum type
e814063 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
cppcodec macro
bbddad4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
numeric limits
b12bdcd 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
if return
856d7f4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
likely
5bb57a4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
self from void
b853b9a 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
example
22699ad 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
sizeof
ef17c47 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
rename
9814d46 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
rename self
387193e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
error text
0bfb4fd 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
comment
b9d83cc 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
comment
90b06ab 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
comment
a34d339 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
variant get
25c3e6d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
hash constraint
6aa4b49 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon February 18, 2025 09:53
@turuslan
revert optional
4c9e48b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
xDimon reviewed Feb 25, 2025
View reviewed changes
Comment thread src/snp/connections/lsquic/engine.cpp Outdated
Comment thread src/snp/connections/lsquic/engine.cpp Outdated
Comment thread src/snp/connections/lsquic/engine.cpp
reading_.remote_endpoint.data(),
&len);
if (n == -1) {
if (errno == EAGAIN or errno == EWOULDBLOCK) {

@xDimon xDimon Feb 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. case of transport (aka network interface, eth0, wifi0, etc.) is closed/ubreacheble/off

Comment thread src/snp/connections/lsquic/engine.hpp Outdated
Comment thread src/snp/connections/lsquic/log.hpp
@xDimon

xDimon commented Feb 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Would be better to cover new mechanics by tests...

@turuslan
update qtils
f5b2466 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
soralog
927632c 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
if
e97ecc8 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
make shared
4572529 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
revert "make shared"
bb881b5 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
port type
812e33f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
shutdown
2eaf302 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove
5632697 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
log socket read/write error
790ce87 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon March 3, 2025 12:55
xDimon
xDimon requested changes Mar 14, 2025
View reviewed changes
Comment thread src/log/simple.hpp Outdated
Comment thread src/snp/connections/lsquic/engine.hpp Outdated
Comment thread src/TODO_qtils/map_entry.hpp Outdated
turuslan added 5 commits March 21, 2025 10:07
@turuslan
Merge remote-tracking branch 'origin/master' into snp/quic
7526bb9 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>

# Conflicts:
#	vcpkg-overlay/qtils/portfile.cmake
#	vcpkg-overlay/scale/portfile.cmake
@turuslan
soralog constructor
b932469 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
build md
7169543 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
make shared private
b4173f0 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
rename
5b679c7 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon March 31, 2025 14:58
xDimon
xDimon reviewed Apr 8, 2025
View reviewed changes
Comment thread src/TODO_qtils/map_entry.hpp Outdated
Comment thread src/TODO_qtils/make_shared_private.hpp Outdated
turuslan added 5 commits April 11, 2025 13:15
@turuslan
rename
e8b2c10 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
deprecated
a22e48b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
singleton connection id counter
4443997 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
CREATE_SHARED_METHOD
f40fcb4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
test
d6e0106 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon April 23, 2025 13:25
xDimon
xDimon approved these changes Apr 23, 2025
View reviewed changes
Comment thread src/crypto/ed25519_literal.hpp
@turuslan
move file
943204b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xDimon xDimon xDimon approved these changes

@iceseer iceseer Awaiting requested review from iceseer

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turuslan @xDimon