Feature/nix support#2257
Open
Lederstrumpf wants to merge 34 commits into
Open
Conversation
fe5f1ce to
6640b1e
Compare
429bc1e to
430a61d
Compare
efc8bd4 to
aa546d5
Compare
7a6d62a to
8a36662
Compare
Contributor
Author
|
opening up for review since this now only requires the following cmake override: for this issue: [ 29%] Building C object CMakeFiles/crypto.dir/crypto/asn1/a_type.c.o
[ 29%] Building C object CMakeFiles/crypto.dir/crypto/asn1/a_utctm.c.o
In file included from /nix/store/m3cz66vv8phy8ywkc7m99vjf0gdx5yyc-glibc-2.39-52-dev/include/string.h:548,
from /home/lederstrumpf/.hunter/_Base/f2d79db/4d672ab/b98f023/Build/BoringSSL/Source/crypto/asn1/a_bitstr.c:60:
In function ‘memcpy’,
inlined from ‘OPENSSL_memcpy’ at /home/lederstrumpf/.hunter/_Base/f2d79db/4d672ab/b98f023/Build/BoringSSL/Source/crypto/asn1/../internal.h:1045:10,
inlined from ‘i2c_ASN1_BIT_STRING’ at /home/lederstrumpf/.hunter/_Base/f2d79db/4d672ab/b98f023/Build/BoringSSL/Source/crypto/asn1/a_bitstr.c:130:3:
/nix/store/m3cz66vv8phy8ywkc7m99vjf0gdx5yyc-glibc-2.39-52-dev/include/bits/string_fortified.h:29:10: error: ‘__builtin_memcpy’ specified bound between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
29 | return __builtin___memcpy_chk (__dest, __src, __len,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
30 | __glibc_objsize0 (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 30%] Building C object CMakeFiles/crypto.dir/crypto/asn1/asn1_lib.c.o
cc1: all warnings being treated as errorsif the related fix (https://github.com/qdrvm/boringssl/tree/fix/remove-werror) is merged into https://github.com/qdrvm/boringssl/tree/master, then I can also remove this override. |
9066d60 to
8fca817
Compare
They should be set on Ubuntu, but not Nix: for Nix, .cargo and .rustup should be within project repo to not pollute system.
1. else, the venv belongs to sudo user 2. FLAKE_INITIATED flag is unset in root's environment (unless direnv or `nix develop` invoked via sudo user)
8fca817 to
42bbaf5
Compare
dc657e0 to
8a71806
Compare
05e907a to
32109f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Implementation of nix shell/flake to build with nix package manager / NixOS.
Tries to strike a balance between Nix conventions and Kagome's current build workflow to be minimally invasive.
To test on NixOS or with the Nix package manager available, call
nix developin the root dir to instantiate a shell.Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: