Skip to content

Fix block benchmark freeezing at the end and add storage extension stats#2436

Open
Harrm wants to merge 9 commits into
masterfrom
fix/block-benchmark
Open

Fix block benchmark freeezing at the end and add storage extension stats#2436
Harrm wants to merge 9 commits into
masterfrom
fix/block-benchmark

Conversation

@Harrm

@Harrm Harrm commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Referenced issues

Description of the Change

Block benchmark used to be frozen at the end of its execution due to how Watchdog works. It is fixed.
Also, add some simple measurements to StorageExtension since it has some significant impact on performance.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? No
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm requested review from igor-egorov and kamilsa April 11, 2025 15:18
@Harrm Harrm marked this pull request as ready for review April 11, 2025 15:19
@kamilsa kamilsa requested a review from Copilot April 14, 2025 11:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • cmake/san.cmake: Language not supported
  • cmake/toolchain/flags/sanitize_address.cmake: Language not supported
  • cmake/toolchain/flags/sanitize_undefined.cmake: Language not supported
Comments suppressed due to low confidence (1)

core/host_api/impl/storage_extension.cpp:36

  • [nitpick] Consider encapsulating the macro's variable declarations inside a do { ... } while(0) block or an immediately invoked lambda to avoid potential name clashes in the surrounding scope.
#define KAGOME_STORAGE_EXTENSION_STATS(action)                       \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants