Fix block benchmark freeezing at the end and add storage extension stats#2436
Open
Harrm wants to merge 9 commits into
Open
Fix block benchmark freeezing at the end and add storage extension stats#2436Harrm wants to merge 9 commits into
Harrm wants to merge 9 commits into
Conversation
igor-egorov
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (3)
- cmake/san.cmake: Language not supported
- cmake/toolchain/flags/sanitize_address.cmake: Language not supported
- cmake/toolchain/flags/sanitize_undefined.cmake: Language not supported
Comments suppressed due to low confidence (1)
core/host_api/impl/storage_extension.cpp:36
- [nitpick] Consider encapsulating the macro's variable declarations inside a do { ... } while(0) block or an immediately invoked lambda to avoid potential name clashes in the surrounding scope.
#define KAGOME_STORAGE_EXTENSION_STATS(action) \
kamilsa
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Block benchmark used to be frozen at the end of its execution due to how Watchdog works. It is fixed.
Also, add some simple measurements to StorageExtension since it has some significant impact on performance.
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: