Skip to content

Vote count for v5 extrinsics, specifically on Westend#2457

Open
ErakhtinB wants to merge 1 commit into
masterfrom
feature/extrinsic_v5_vote_counting
Open

Vote count for v5 extrinsics, specifically on Westend#2457
ErakhtinB wants to merge 1 commit into
masterfrom
feature/extrinsic_v5_vote_counting

Conversation

@ErakhtinB

Copy link
Copy Markdown
Contributor

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@ErakhtinB ErakhtinB requested review from iceseer and kamilsa May 19, 2025 07:24
@kamilsa kamilsa requested a review from Copilot May 26, 2025 14:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for v5 extrinsics in the parachain vote count processing on Westend by adding new constants and refactoring the extrinsic decoding logic. Key changes include:

  • Adding v5-specific extrinsic version and call constants.
  • Refactoring the extrinsic decoding logic with a lambda that handles version selection.
  • Updating the type of the persisted validation data reference to be const.
Comments suppressed due to low confidence (1)

core/parachain/validator/impl/parachain_processor.cpp:3507

  • The parameter 'version_str' in the lambda is currently unused; consider removing it or incorporating it into error logging to improve clarity.
const auto tryDecodeExtrinsic = [&](uint8_t version, uint8_t call, const char *version_str) -> std::optional<parachain::ParachainInherentData> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants