Vote count for v5 extrinsics, specifically on Westend#2457
Open
ErakhtinB wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for v5 extrinsics in the parachain vote count processing on Westend by adding new constants and refactoring the extrinsic decoding logic. Key changes include:
- Adding v5-specific extrinsic version and call constants.
- Refactoring the extrinsic decoding logic with a lambda that handles version selection.
- Updating the type of the persisted validation data reference to be const.
Comments suppressed due to low confidence (1)
core/parachain/validator/impl/parachain_processor.cpp:3507
- The parameter 'version_str' in the lambda is currently unused; consider removing it or incorporating it into error logging to improve clarity.
const auto tryDecodeExtrinsic = [&](uint8_t version, uint8_t call, const char *version_str) -> std::optional<parachain::ParachainInherentData> {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: