Skip to content

[feat] add TTL for grandpa historical votes and update storage spaces #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamilsa wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −4
Open

[feat] add TTL for grandpa historical votes and update storage spaces #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c30728
[feat] add TTL for grandpa historical votes and update storage spaces
kamilsa Jun 12, 2025
65ac501
Merge branch 'master' into feature/hist-votes-ttl
kamilsa Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/consensus/grandpa/impl/grandpa_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ namespace kagome::consensus::grandpa {
constexpr std::chrono::milliseconds kGossipDuration{1000};

inline auto historicalVotesKey(AuthoritySetId set, RoundNumber round) {
auto key = storage::kGrandpaHistoricalVotesPrefix;
common::Buffer key;

@xDimon xDimon Jun 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused anymore key storage::kGrandpaHistoricalVotesPrefix

key.putUint64(set);
key.putUint64(round);
return key;
Expand Down Expand Up @@ -102,7 +102,7 @@ namespace kagome::consensus::grandpa {
reputation_repository_(std::move(reputation_repository)),
timeline_{timeline},
chain_sub_{std::move(chain_sub_engine)},
db_{db.getSpace(storage::Space::kDefault)},
db_{db.getSpace(storage::Space::kGrandpaHistoricalVotes)},
main_pool_handler_{main_thread_pool.handler(*app_state_manager)},
grandpa_pool_handler_{poolHandlerReadyMake(
this, app_state_manager, grandpa_thread_pool, logger_)},
Expand Down
3 changes: 2 additions & 1 deletion core/injector/application_injector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ namespace {
options.max_open_files = soft_limit.value() / 2;

const std::unordered_map<std::string, int32_t> column_ttl = {
{"avaliability_storage", 25 * 60 * 60}}; // 25 hours
{"avaliability_storage", 25 * 60 * 60}, // 25 hours
{"grandpa_historical_votes", 2 * 60}}; // 2 minutes
auto db_res =
storage::RocksDb::create(app_config.databasePath(chain_spec->id()),
options,
Expand Down
3 changes: 2 additions & 1 deletion core/storage/rocksdb/rocksdb_spaces.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ namespace kagome::storage {
"dispute_data",
"beefy_justification",
"avaliability_storage",
"audi_peers"};
"audi_peers",
"grandpa_historical_votes"};
static_assert(kNames.size() == Space::kTotal - 1);

std::string spaceName(Space space) {
Expand Down
1 change: 1 addition & 0 deletions core/storage/spaces.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ namespace kagome::storage {
kBeefyJustification,
kAvaliabilityStorage,
kAudiPeers,
kGrandpaHistoricalVotes,

kTotal
};
Expand Down
Loading