Skip to content

feat(executor): make opencode request timeout configurable#2411

Merged
alekspetrov merged 1 commit intoqf-studio:mainfrom
myagizmaktav:feat/configurable-execution-timeout
Apr 29, 2026
Merged

feat(executor): make opencode request timeout configurable#2411
alekspetrov merged 1 commit intoqf-studio:mainfrom
myagizmaktav:feat/configurable-execution-timeout

Conversation

@myagizmaktav
Copy link
Copy Markdown
Contributor

Summary

  • add executor.opencode.request_timeout so OpenCode HTTP request lifetime is configurable
  • keep backward compatibility by defaulting to 10m when unset or invalid
  • cover timeout parsing and backend client wiring with focused tests

Example

executor:
  opencode:
    request_timeout: 20m

Verification

  • go test ./internal/executor -run 'TestOpenCodeConfig|TestOpenCodeConfigEffectiveRequestTimeout|TestNewOpenCodeBackend' -count=1 -v
  • make build

Closes #2410

@alekspetrov
Copy link
Copy Markdown
Collaborator

Thanks! The conflict is from commit 8663915 which duplicates the OpenCode message-schema fix that already shipped in v2.100.3 (PR #2414). Could you rebase off main and drop that commit, leaving only 8fc1c31 (the timeout config)? After rebase the diff should be limited to: backend.go, backend_opencode.go (timeout fields only), and the new backend_opencode_test.go cases for timeout parsing. Health-check changes can also drop if v2.100.3 already covers them.

@alekspetrov alekspetrov force-pushed the feat/configurable-execution-timeout branch from 8fc1c31 to 7fedd52 Compare April 29, 2026 20:50
@alekspetrov
Copy link
Copy Markdown
Collaborator

Rebased onto current main and force-pushed. Dropped the stale schema-fix commit (8663915) — that was already shipped in v2.100.3 / PR #2414. Kept only the timeout config commit (8fc1c31). Diff is now +58/−3 (down from +442/−43). Authorship preserved.

Will need workflow approval on the Checks tab to run CI.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@alekspetrov alekspetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adds executor.opencode.request_timeout with 10m default, validation, and tests. Rebased onto current main.

@alekspetrov alekspetrov merged commit 697c13e into qf-studio:main Apr 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make OpenCode HTTP request timeout configurable

3 participants