Fix/38 musl ioctl redo - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
bux-guestmusl build.FIFREEZE/FITHAWwere typed aslibc::c_ulong, which only matches glibc'sioctl(int, unsigned long, ...)— musl follows POSIX withioctl(int, int, ...), so both call sites failed with E0308 on the only targetsbux-guestships for.This is a regression: the same fix landed in
03a2a0b(#39) but was dropped when that merge fell out ofmain's history.Changes
libc::Ioctlso the request width follows the target libcu32literals — the width the kernel actually reads; zero-extends on glibc, wraps toc_inton musl, same low 32 bits either wayVerified on both musl targets plus gnu: release builds,
clippy -- -D warnings, andfmt --checkall pass.Closes #38