Skip to content

fix - Unset the MAGEBOX_PHP_WRAPPER in the PHP wrapper before running… #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterjaap wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix - Unset the MAGEBOX_PHP_WRAPPER in the PHP wrapper before running… #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions internal/phpwrapper/templates/php.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@ if [[ -n "$project_dir" ]]; then
if [[ -n "$php_version" ]]; then
php_bin=$(find_php_binary "$php_version")
if [[ -n "$php_bin" ]]; then
# Set Magento-friendly defaults for CLI (unlimited memory for compile/deploy)
exec "$php_bin" -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
# Unset MAGEBOX_PHP_WRAPPER so child processes spawned by the real PHP
# binary (e.g. #!/usr/bin/env php scripts run by GrumPHP tasks) do not
# inherit the recursion guard and falsely trigger the error.
exec env -u MAGEBOX_PHP_WRAPPER "$php_bin" -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
else
echo "Error: PHP $php_version not found. Install with: brew install php@$php_version" >&2
exit 1
Expand All @@ -125,11 +127,11 @@ fi

# Fallback to system PHP (no config file found)
if command -v /opt/homebrew/bin/php &> /dev/null; then
exec /opt/homebrew/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
exec env -u MAGEBOX_PHP_WRAPPER /opt/homebrew/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
elif command -v /usr/local/bin/php &> /dev/null; then
exec /usr/local/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
exec env -u MAGEBOX_PHP_WRAPPER /usr/local/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
elif command -v /usr/bin/php &> /dev/null; then
exec /usr/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
exec env -u MAGEBOX_PHP_WRAPPER /usr/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
else
echo "Error: No PHP installation found" >&2
exit 1
Expand Down
12 changes: 7 additions & 5 deletions lib/templates/wrappers/php.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@ if [[ -n "$project_dir" ]]; then
if [[ -n "$php_version" ]]; then
php_bin=$(find_php_binary "$php_version")
if [[ -n "$php_bin" ]]; then
# Set Magento-friendly defaults for CLI (unlimited memory for compile/deploy)
exec "$php_bin" -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
# Unset MAGEBOX_PHP_WRAPPER so child processes spawned by the real PHP
# binary (e.g. #!/usr/bin/env php scripts run by GrumPHP tasks) do not
# inherit the recursion guard and falsely trigger the error.
exec env -u MAGEBOX_PHP_WRAPPER "$php_bin" -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
else
echo "Error: PHP $php_version not found. Install with: brew install php@$php_version" >&2
exit 1
Expand All @@ -125,11 +127,11 @@ fi

# Fallback to system PHP (no config file found)
if command -v /opt/homebrew/bin/php &> /dev/null; then
exec /opt/homebrew/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
exec env -u MAGEBOX_PHP_WRAPPER /opt/homebrew/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
elif command -v /usr/local/bin/php &> /dev/null; then
exec /usr/local/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
exec env -u MAGEBOX_PHP_WRAPPER /usr/local/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
elif command -v /usr/bin/php &> /dev/null; then
exec /usr/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
exec env -u MAGEBOX_PHP_WRAPPER /usr/bin/php -d memory_limit=-1 -d opcache.enable_cli=0 "$@"
else
echo "Error: No PHP installation found" >&2
exit 1
Expand Down
Loading