[6111][ADD] product_restricted_tracking#223
Open
SanamiK wants to merge 7 commits into
Open
Conversation
AungKoKoLin1997
approved these changes
Apr 16, 2026
yostashiro
requested changes
Apr 16, 2026
Comment on lines
+11
to
+24
| categ_id_domain = fields.Binary( | ||
| string="Category Domain", | ||
| compute="_compute_categ_id_domain", | ||
| help="Dynamic domain used for filtering allowed categories based on tracking", | ||
| ) | ||
|
|
||
| @api.depends("tracking") | ||
| def _compute_categ_id_domain(self): | ||
| for record in self: | ||
| record.categ_id_domain = [ | ||
| "|", | ||
| ("restricted_tracking", "=", False), | ||
| ("restricted_tracking", "=", record.tracking), | ||
| ] |
Member
There was a problem hiding this comment.
See my comment in the corresponding OCA PR.
Suggested change
| categ_id_domain = fields.Binary( | |
| string="Category Domain", | |
| compute="_compute_categ_id_domain", | |
| help="Dynamic domain used for filtering allowed categories based on tracking", | |
| ) | |
| @api.depends("tracking") | |
| def _compute_categ_id_domain(self): | |
| for record in self: | |
| record.categ_id_domain = [ | |
| "|", | |
| ("restricted_tracking", "=", False), | |
| ("restricted_tracking", "=", record.tracking), | |
| ] |
Member
Author
There was a problem hiding this comment.
Since that was the feature I had trouble with when testing so I feel it is a nice improvement.
I'll fix the issue later.
Contributor
|
@SanamiK |
Contributor
|
@SanamiK I don't know why you close but I updated in the OCA and you can apply the same in your PR. |
Member
Author
|
@nobuQuartile Yes, I'll reopen it after fixing the issue. |
Member
Author
|
Done! |
yostashiro
reviewed
Apr 17, 2026
SanamiK
force-pushed
the
6111-add-product_restricted_tracking
branch
from
f4a4acc to
aaa998e
Compare
…d and apply translations to dropdown menus
SanamiK
force-pushed
the
6111-add-product_restricted_tracking
branch
from
aaa998e to
1ff58fb
Compare
Member
Author
|
@nobuQuartile I accidentally ended up combining multiple commits, but could you please review the current version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6111
Translation
product_restricted_tracking/i18n/ja.poproduct_restricted_tracking/i18n/ja.poodoo/stockodoo/stockodoo/stock\n... and %s more product(s)\n... さらに %s 件のプロダクトCannot set restricted tracking to '%(tracking)s' because %(count)s product(s) in this category have different tracking:\n%(products)s%(more)sこのカテゴリの %(count)s 件のプロダクトが異なる追跡を持っているため、追跡の制限を '%(tracking)s' に設定できません:\n%(products)s%(more)sProduct '%(product)s' has tracking '%(tracking)s' but is assigned to category '%(category)s' which requires tracking '%(required_tracking)s'.プロダクト '%(product)s' は追跡 '%(tracking)s' を持っていますが、追跡 '%(required_tracking)s' が必要なカテゴリ '%(category)s' に割り当てられています。