fix(provisioning): tolerate non-UTF-8 SSH output - #84
Merged
Conversation
Remote tools can emit arbitrary model metadata bytes which AsyncSSH's strict UTF-8 decoder treats as a channel failure. This made an otherwise healthy llama.cpp startup fail while runtime verification read its log. Decode command output as UTF-8 with replacement for both streaming and collected commands. Exact ASCII runtime evidence remains fail-closed, while invalid bytes in unrelated diagnostic output no longer abort SSH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
AsyncSSH inherited strict UTF-8 decoding for remote command sessions. The llama.cpp verbosity-4 startup log can contain raw tokenizer or model metadata bytes, so one invalid byte aborted the channel while QIIP read
/var/log/llamacpp-serve.log. The server had started successfully, but runtime verification never reached the valid fit records later in the log.Testing
git diff --check: clean