Skip to content

Sync upstream moq-dev to 3c6002a#11

Merged
JoaquinBCh merged 591 commits into
benchmark-developfrom
sync/moq-dev-3c6002a
Jun 5, 2026
Merged

Sync upstream moq-dev to 3c6002a#11
JoaquinBCh merged 591 commits into
benchmark-developfrom
sync/moq-dev-3c6002a

Conversation

@JoaquinBCh

@JoaquinBCh JoaquinBCh commented Jun 5, 2026

Copy link
Copy Markdown

No description provided.

kixelated and others added 30 commits April 9, 2026 11:40
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
The relay sometimes takes longer than 60 seconds to start,
causing the demo to fail prematurely.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nd ignored (moq-dev#1275)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: moq-bot[bot] <186640430+moq-bot[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
…ev#1286)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: moq-bot[bot] <186640430+moq-bot[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kixelated and others added 27 commits May 29, 2026 17:22
moq-dev#1545)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…ns (moq-dev#1544)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…1546)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…mers (moq-dev#1549)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: moq-bot[bot] <186640430+moq-bot[bot]@users.noreply.github.com>
Co-authored-by: Luke Curley <kixelated@gmail.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…-dev#1552)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: moq-bot[bot] <186640430+moq-bot[bot]@users.noreply.github.com>
moq-dev#1555)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… packages (moq-dev#1551)

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…lease caveat (moq-dev#1564)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
…ab06e525ea302f2a56f5e182f33cfd14fa to 89c01715e5d0dfdc0a1bfe9d59891ee4945c1483 (moq-dev#1567)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-dev#1568)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ev#1565)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…v#1570)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…gossip (moq-dev#1571)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…oq-dev#1572)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…v#1574)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: moq-bot[bot] <186640430+moq-bot[bot]@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a major restructuring of the repository, renaming the core transport layer from moq-lite to moq-net and adding a crowd-controlled Game Boy Color emulator demo (MoQ Boy) with on-demand encoding. It also introduces GStreamer plugin support, C bindings, and language wrappers for Python, Kotlin, Swift, and Go, while replacing the Terraform infrastructure with local-first setups and updating the documentation. The review feedback highlights a potential TypeError in the web discover script due to uninitialized connection properties, and recommends adding defensive checks in the release script when writing to GITHUB_OUTPUT to prevent errors during local execution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +24 to +27
if [[ "$ref" =~ ^${prefix}-v([0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?(\+[0-9A-Za-z.-]+)?)$ ]]; then
local version="${BASH_REMATCH[1]}"
echo "version=${version}" >>"$GITHUB_OUTPUT"
echo "Parsed version: ${version}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

En la función parse_version, se intenta escribir directamente en $GITHUB_OUTPUT sin verificar si la variable está definida. Esto provocará un error de redirección ambigua (ambiguous redirect) si el script se ejecuta localmente o en un entorno donde GITHUB_OUTPUT no esté configurado. Se recomienda añadir una comprobación defensiva similar a la que se utiliza en otras partes del script.

Suggested change
if [[ "$ref" =~ ^${prefix}-v([0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?(\+[0-9A-Za-z.-]+)?)$ ]]; then
local version="${BASH_REMATCH[1]}"
echo "version=${version}" >>"$GITHUB_OUTPUT"
echo "Parsed version: ${version}"
if [[ "$ref" =~ ^${prefix}-v([0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?(\+[0-9A-Za-z.-]+)?)$ ]]; then
local version="${BASH_REMATCH[1]}"
if [[ -n "${GITHUB_OUTPUT:-}" ]]; then
echo "version=${version}" >>"$GITHUB_OUTPUT"
fi
echo "Parsed version: ${version}"

Comment on lines +44 to +45
echo "tag=${prev}" >>"$GITHUB_OUTPUT"
echo "Previous tag: ${prev:-none}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

En la función prev_tag, se intenta escribir directamente en $GITHUB_OUTPUT sin verificar si la variable está definida. Esto provocará un error de redirección ambigua (ambiguous redirect) si el script se ejecuta localmente o en un entorno donde GITHUB_OUTPUT no esté configurado. Se recomienda añadir una comprobación defensiva.

Suggested change
echo "tag=${prev}" >>"$GITHUB_OUTPUT"
echo "Previous tag: ${prev:-none}"
if [[ -n "${GITHUB_OUTPUT:-}" ]]; then
echo "tag=${prev}" >>"$GITHUB_OUTPUT"
fi
echo "Previous tag: ${prev:-none}"

Comment thread demo/web/src/discover.ts
Comment on lines +32 to +34
this.#signals.run((effect) => {
const broadcasts = effect.get(watch.connection.announced);
const selected = effect.get(watch.broadcast.name).toString();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Dado que la conexión y la transmisión de moq-watch se inicializan de forma asíncrona, es posible que watch.connection o watch.broadcast sean undefined o null en el momento en que se ejecuta este efecto. Acceder a sus propiedades directamente sin una comprobación previa provocará un error de tipo (TypeError). Se recomienda añadir una salvaguarda defensiva.

Suggested change
this.#signals.run((effect) => {
const broadcasts = effect.get(watch.connection.announced);
const selected = effect.get(watch.broadcast.name).toString();
this.#signals.run((effect) => {
if (!watch.connection || !watch.broadcast) return;
const broadcasts = effect.get(watch.connection.announced);
const selected = effect.get(watch.broadcast.name).toString();

@JoaquinBCh
JoaquinBCh merged commit a926c5c into benchmark-develop Jun 5, 2026
54 checks passed
@JoaquinBCh
JoaquinBCh deleted the sync/moq-dev-3c6002a branch June 5, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.