Feat/response received#21
Draft
cotid-qualabs wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request significantly refactors the CMCD Manager by deprecating 'response mode' and instead leveraging a new 'response received' (rr) event within the existing event-based reporting system.
Highlights
V2ResponseModeKeyshave been merged intoV2EventModeKeys.rc) and CMSD headers (cmsds,cmsdd) are now directly included in the data payload for the newrrevent, ensuring comprehensive reporting.sn) logic has been implemented for response events, allowing for better tracking of event order across multiple targets.Changelog
responseproperty fromthis.msdSent_object.applyResponseDatato trigger a newrrevent, incorporating previous response mode logic.data.rc) and CMSD headers (data.cmsds,data.cmsdd) into therrevent data payload.reportEvent_calls to use consistent quoted keys for object literals (e.g.,'sta': 'r').V2ResponseModeKeysintoV2EventModeKeys.'rr'(Response Received) to the list ofCmcdV2Events.sn) tracking for response events withinreportEvent_.requestTimestampMap_entries if norrevent is configured for a request.getResponseModeEnabledTargets()tohasResponseReceived_()and updated its logic to check for therrevent in target configurations.rrevents.networkingEnginespies, reflecting the internal request mechanism for event reporting.mode: 'response'and includeevents: ['rr']where applicable.