Skip to content

display: synchronize macOS SDL window creation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jerome Haxhiaj (jeromehaxhiaj-qti) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

display: synchronize macOS SDL window creation #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions qemu-components/display/src/display.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,23 @@ void MainThreadQemuDisplay::window_create(DisplayChangeListener* dcl)
{
qemu::LibQemu& lib = inst->get();
MainThreadQemuDisplay* display = reinterpret_cast<MainThreadQemuDisplay*>(lib.dcl_new(dcl).get_user_data());
// SDL2 window create should run on main-thread
display->m_on_sysc.fork_on_systemc([&lib, dcl]() { lib.sdl2_window_create(dcl); });

/*
* GL switch continues immediately with context and texture creation, so
* the macOS window must exist before the callback returns. During
* elaboration, keep the callback asynchronous to avoid the startup
* deadlock; once simulation is running, release BQL while synchronously
* rendezvousing with the SystemC thread.
*/
if (display->m_simulation_started) {
lib.unlock_iothread();
}

display->m_on_sysc.run_on_sysc([&lib, dcl]() { lib.sdl2_window_create(dcl); }, display->m_simulation_started);

if (display->m_simulation_started) {
lib.lock_iothread();
}
}

void MainThreadQemuDisplay::window_destroy(DisplayChangeListener* dcl)
Expand Down
Loading