systemc-components/addrtr: fix an issue in the map_dmi_start_end_addr… - #115
Merged
Conversation
mahmdkamel
requested review from
Alwalid Salama (alwalidsalama),
Mark Burton (markfoodyburton) and
Thomas Mrcn (tmarcero)
September 2, 2026 11:02
mahmdkamel
force-pushed
the
fix_addrtr_issue
branch
from
September 2, 2026 11:39
5fe54fa to
7d13154
Compare
… function - The end_addr in the function map_dmi_start_end_addr() which is used to transform the get_direct_mem_ptr was checked wrongly against the modified start_addr, check it correctly against p_mapped_base_addr. - Modify the test bench to accomodate the change. Signed-off-by: Mahmoud Kamel <mkamel@qti.qualcomm.com>
mahmdkamel
force-pushed
the
fix_addrtr_issue
branch
from
September 2, 2026 11:45
7d13154 to
afce687
Compare
Thomas Mrcn (tmarcero)
approved these changes
Sep 2, 2026
Brian Cain (androm3da)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… function