Added the logic to package the libusb dll with the userspace installer#16
Merged
Merged
Conversation
Signed-off-by: Tejas Sharma <tejashar@qti.qualcomm.com>
tejas27 (tejas-sharma27)
force-pushed
the
libusb-dll-package-integration
branch
from
cccf47d to
2749b12
Compare
Chenxi Han (5656hcx)
requested changes
Jun 9, 2026
Chenxi Han (5656hcx)
left a comment
Chenxi Han (5656hcx)
left a comment
Contributor
There was a problem hiding this comment.
Good changes. Outputs as expected.
One major concern I have:
Pre-compiled binary DLLs committed directly to the repository.
Adding binaries to git inflates the repository size and make history tracking difficult. Also, there is no source of the binaries, is it generated by ourself or downloaded from libusb?
I will recommend downloading libusb at build time, like
$libusbVersion = "1.0.27"
$libusbUrl = "https://github.com/libusb/libusb/releases/download/v$libusbVersion/libusb-$libusbVersion-binaries.7z"
# Download, optionally verify SHA-256, and extract libusb/<arch>/dll/libusb-1.0.dll
Or alternatively, we download the .dll manually somewhere at build time, then build script copies it to the payload.
… the libusb dlls during build time Signed-off-by: Tejas Sharma <tejashar@qti.qualcomm.com>
tejas27 (tejas-sharma27)
force-pushed
the
libusb-dll-package-integration
branch
from
8cfdbdf to
08c97ac
Compare
Contributor
Author
|
I have removed the libusb dlls directory from the commit. As suggested by Chenxi Han (@5656hcx), I have added the logic to download the libusb during build time and use the downloaded zip to create the libusb directory from which staging files will be picked. |
Chenxi Han (5656hcx)
requested changes
Jun 10, 2026
Chenxi Han (5656hcx)
approved these changes
Jun 11, 2026
Chenxi Han (5656hcx)
force-pushed
the
libusb-dll-package-integration
branch
from
6917910 to
4f96781
Compare
Signed-off-by: Chenxi Han <chehan@qti.qualcomm.com>
Chenxi Han (5656hcx)
force-pushed
the
libusb-dll-package-integration
branch
from
4f96781 to
46504c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for packaging architecture-specific libusb binaries into the installer payload. Instead of bundling all architectures, the build process now selectively includes only the required libusb/ directory based on an input parameter.
Tested by running the installer locally and verifying that payload.zip contains the directory.