qdinstall: fix race condition on re-install by splitting uninstall modes#19
Merged
Conversation
Signed-off-by: Chenxi Han <chehan@qti.qualcomm.com>
Chenxi Han (5656hcx)
requested review from
hangzqcom,
rohimish-qc and
Shashank Arora (shasaror)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug introduced in 1.0.2.1 installer.
Root Cause
The newly added feature in qdinstall will start a delayed command prompt to delete installation files.
This process is not synchronized with outer installer shell and will accidentally delete newly copied files.
Fix
Split uninstall mode into "uninstall" and "remove". Outer installer will handle files deletion by itself only.
Test
Local test passed.