Ship FreeCut v1 Editor Hardening and Shortcut Controls - #30
Conversation
(cherry picked from commit c022a15)
(cherry picked from commit 10f7758)
(cherry picked from commit 3058b32)
(cherry picked from commit 86bb526)
(cherry picked from commit 4f64f8e)
(cherry picked from commit c85bf58)
(cherry picked from commit f5adb69)
(cherry picked from commit 1e3535b)
(cherry picked from commit 9bd1f37)
(cherry picked from commit b011124)
(cherry picked from commit 8e882eb)
(cherry picked from commit 7402738)
(cherry picked from commit fadb8a6)
(cherry picked from commit 7837f21)
(cherry picked from commit 5cf81b4)
(cherry picked from commit b987c81)
(cherry picked from commit a92c12f)
(cherry picked from commit 1f8df90)
(cherry picked from commit 7d34974)
(cherry picked from commit e80e35b)
(cherry picked from commit 977473c)
(cherry picked from commit 5f31b1c)
(cherry picked from commit c0c288f)
(cherry picked from commit 9cf093b)
(cherry picked from commit 448a00f)
(cherry picked from commit af56cb4)
(cherry picked from commit 722cac7)
(cherry picked from commit d731f64)
(cherry picked from commit 861d348)
(cherry picked from commit f45ca69)
(cherry picked from commit d7a400c)
(cherry picked from commit d514f19)
(cherry picked from commit 541085c)
(cherry picked from commit 0f5602d)
(cherry picked from commit 0e71126)
(cherry picked from commit 93d57a2)
(cherry picked from commit 8388082)
(cherry picked from commit dc40a83)
(cherry picked from commit 026c62d)
(cherry picked from commit 0eda4ba)
(cherry picked from commit 3a69802)
(cherry picked from commit 62e6c1d)
(cherry picked from commit 25f751d)
(cherry picked from commit 3726994)
Exact-head frontend QA: FAILQA at
|
(cherry picked from commit f22464674582b2afe987cbb3486ddc60fd7d53ea)
(cherry picked from commit c9494a515e27074482bf7ba8bbd1998f4fc8ced3)
(cherry picked from commit bec5c41eea03db70b08ec4506e2a6a72c458e37b)
(cherry picked from commit e0bd5e66011fdb7646c8be2b8939a172dd68bc30)
|
Starting initial review of |
There was a problem hiding this comment.
The reviewed shortcut and embedded-surface changes have a sound ownership shape: runtime registration is centralized, platform aliases are resolved before registration, and host-owned shortcut settings remain behind a versioned port with replacement fencing.
I am leaving this as a comment rather than approving. The PR itself still lists the combined exact-head browser QA as incomplete, and this release integration spans 200 changed files with a large set of omitted/truncated source patches. The focused paths inspected here do not produce an actionable defect, but the outstanding exact-head QA and remaining integration surface need completion before a merge-ready determination.
Coverage
This review is partial because some textual changes were not fully supplied or inspected. The automation will not submit an approval until those paths are reviewed.
scripts/runtime-hotkey-import-boundary.mjs(patch_too_large)src/config/hotkeys.test.ts(patch_too_large)src/config/hotkeys.ts(patch_too_large)src/config/runtime-hotkey-registration-coverage.test.ts(diff_budget_exceeded)src/features/editor/components/editor.tsx(diff_budget_exceeded)src/features/editor/components/media-sidebar.tsx(diff_budget_exceeded)src/features/editor/components/preview-area.tsx(diff_budget_exceeded)src/features/editor/components/properties-sidebar/index.tsx(diff_budget_exceeded)src/features/editor/components/toolbar.tsx(diff_budget_exceeded)src/features/editor/components/workspace-switcher.tsx(diff_budget_exceeded)- ... and 157 more pending file(s)
|
Review head |
Summary
This release integration brings FreeCut’s core editing experience to a releasable v1 baseline: reliable source playback and seeking, faster cutting and ripple workflows, atomic lock and linked-clip behavior, safer exports, and discoverable host-configurable shortcuts. It combines the independently reviewed work from PRs #25–#29 and publishes the editor surface as version 0.3.9 for CodePress to consume.
Technical details
codepress-mainwithout importing unrelated ancestry: 54 source commits retain-xprovenance, with overlap decisions recorded in the integration manifest.@quantfive/freecut-editor-surfacefrom 0.3.8 to 0.3.9. The deterministic tarball SHA-256 is27855709f334dcac4eda5adc7771c9b0a1fd0b5f47e9a3844c391218ac9ba77c.Test plan
Open items
Demo
Shared-edge rolling trim
Keyboard focus, lock, and timeline overflow
Responsive editor and host surface
Desktop geometry
Interaction recording
Full-quality WebM