Skip to content

deps(deps): bump modernc.org/sqlite from 1.46.1 to 1.52.0#75

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/modernc.org/sqlite-1.52.0
Open

deps(deps): bump modernc.org/sqlite from 1.46.1 to 1.52.0#75
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/modernc.org/sqlite-1.52.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor

Bumps modernc.org/sqlite from 1.46.1 to 1.52.0.

Changelog

Sourced from modernc.org/sqlite's changelog.

Changelog

  • 2026-06-06 v1.52.0:

    • Upgrade to SQLite 3.53.2.
    • Add Backup.Remaining and Backup.PageCount, thin wrappers around the existing sqlite3_backup_remaining and sqlite3_backup_pagecount C symbols. Together they expose the per-Step progress counters that the underlying backup object already maintains, enabling progress reporting during online backups without dropping to modernc.org/sqlite/lib directly.
    • See [GitLab merge request #122](https://gitlab.com/cznic/sqlite/-/merge_requests/122), thanks Ian Chechin!
    • Drop the redundant second copy in (*conn).columnText, the path that backs every Rows.Scan into a Go string for a TEXT column. The value's bytes are still copied once out of SQLite-owned memory into a fresh Go buffer; that buffer is then reinterpreted as the result string with unsafe.String rather than copied a second time by the implicit string([]byte) conversion. This removes one allocation per TEXT value per row and roughly halves the bytes allocated on that path; on the new BenchmarkColumnTextScan cases it is ~13–20% faster for payloads of 256 B and larger, with no measurable change for very short strings. Purely internal: no API or behavioral change, and the returned string never aliases SQLite's buffer.
    • See [GitLab merge request #123](https://gitlab.com/cznic/sqlite/-/merge_requests/123), thanks Ian Chechin!
    • Cache each result column's declared type once per result set in newRows instead of recomputing it on every row. The TEXT branch of Rows.Next calls ColumnTypeDatabaseTypeName for every TEXT column on every row (independent of any DSN flag), which previously did a libc.GoString + strings.ToUpper each time; that lookup is now a single index into a cached, pre-uppercased []string, and ColumnTypeScanType reads the same cache and drops its per-call strings.ToLower. The declared type is fixed for the lifetime of a prepared statement, so the C round-trip is paid once per column rather than once per column per row, removing exactly 1 alloc + 8 B per TEXT column per row from the Next hot path. The new BenchmarkTextToTimeScan cases show ~7% faster on a 1000-row DATETIME SELECT under _texttotime=1. Purely internal: ColumnTypeDatabaseTypeName and ColumnTypeScanType return identical values, no API or behavioral change.
    • See [GitLab merge request #124](https://gitlab.com/cznic/sqlite/-/merge_requests/124), thanks Ian Chechin!
    • Cache, per result column, the parseTimeFormats index that first parsed a TEXT-stored DATE/DATETIME/TIMESTAMP value, and try that format first on later rows instead of re-walking the list from the top. (*conn).parseTime previously ran time.Parse down the format list on every such row; for the canonical SQLite TEXT datetime format every row paid two failed time.Parse attempts — each allocating a *time.ParseError — before the match. On a 1000-row DATETIME TEXT SELECT this cuts ~50% of allocs/op and ~57% of B/op and is ~37% faster. The fall-through chain is preserved exactly: the seven formats are mutually exclusive, so the cached hint can never select a different match than the in-order scan, and the parsed driver.Value is identical to before. Purely internal: no API or behavioral change.
    • See [GitLab merge request #125](https://gitlab.com/cznic/sqlite/-/merge_requests/125), thanks Ian Chechin!

  • 2026-05-28 v1.51.0:

    • Pool the []driver.Value slice passed to scalar/aggregate UDF callbacks and to vtab Filter/Insert/Update callbacks, eliminating the dominant per-row allocation on UDF-heavy queries. Benchmarks on a 1000-row, 3-arg noop scalar UDF show ~40% fewer bytes/op and ~15% fewer allocs/op.
    • Document the matching "arguments are not valid past return" contract on vtab.Cursor.Filter and vtab.Updater.Insert/Update, consistent with the existing rule for FunctionImpl.Scalar / AggregateFunction.Step / WindowInverse.
    • Resolves [GitLab issue #226](https://gitlab.com/cznic/sqlite/-/issues/226). See [GitLab merge request #114](https://gitlab.com/cznic/sqlite/-/merge_requests/114), thanks Ian Chechin!
    • Add FileControl.FileControlDataVersion, a wrapper around SQLITE_FCNTL_DATA_VERSION for observing pager-cache data-version changes, including those made on the same connection. Useful as a primitive for application-level cache invalidation.
    • Exposed via the idiomatic database/sql escape hatch (*sql.Conn).Raw(), consistent with the existing FileControlPersistWAL.
    • See [GitLab merge request #115](https://gitlab.com/cznic/sqlite/-/merge_requests/115), thanks Ian Chechin!
    • Fix a regression where in-memory connections (:memory:, file::memory:, shared-cache memory URIs) were discarded by database/sql after a context-cancelled query, taking the entire in-memory store with them. The fix for #198 had added an sqlite3_is_interrupted check to the connection validator that mistakenly applied to in-memory connections too, re-introducing the bug originally fixed by !74. File-backed connections keep the existing behaviour and are still discarded after an interrupt.
    • Resolves [GitLab issue #196](https://gitlab.com/cznic/sqlite/-/issues/196). See [GitLab merge request #116](https://gitlab.com/cznic/sqlite/-/merge_requests/116), thanks Ian Chechin!
    • Add an opt-in FunctionImpl.VolatileArgs flag that hands TEXT and BLOB arguments to scalar and aggregate UDF callbacks as zero-copy views (unsafe.String/unsafe.Slice) over SQLite's own value buffers, eliminating the per-argument libc.GoString/make([]byte) copy that the #226 slice-pooling left as the remaining per-row allocation. On the same 1000-row, 3-arg (INTEGER/TEXT/BLOB) noop scalar UDF this removes a further ~35% of allocs/op and ~11% of bytes/op on top of #226.
    • The views are valid only for the duration of the callback and must not be retained past return or across rows; a callback that needs to keep a value must copy it. With VolatileArgs unset (the default) arguments keep the existing copied, caller-owned semantics, so the flag is fully backward compatible; it has no effect on integer, float, time, or NULL arguments.
    • See [GitLab merge request #120](https://gitlab.com/cznic/sqlite/-/merge_requests/120), thanks Ian Chechin!
    • Extend the opt-in VolatileArgs zero-copy TEXT/BLOB argument access from #120 to the virtual-table Cursor.Filter (xFilter) and Updater.Insert/Update (xUpdate) callbacks. A vtab.Module opts in by implementing the new optional vtab.VolatileArgsOpter interface (VolatileArgs() bool); the flag is read once at module registration and shared by every table created from it. On a vtab call carrying one TEXT and one BLOB argument this removes 2 allocs/op (one libc.GoString, one make([]byte)) on each of the Filter and Update paths.
    • The same safety contract as #120 applies: the views are valid only for the duration of the callback and must not be retained past return or across rows; a callback that needs to keep a value must copy it. Modules that do not implement VolatileArgsOpter (the default for all existing modules) are byte-for-byte unchanged, and the flag has no effect on integer, float, time, or NULL arguments.
    • See [GitLab merge request #121](https://gitlab.com/cznic/sqlite/-/merge_requests/121), thanks Ian Chechin!

  • 2026-05-10 v1.50.1:

  • 2026-04-24 v1.50.0:

    • Upgrade to sqlite-vec v0.1.9.
    • Introduce ColumnInfo, enabling dynamic query builders and ORMs to retrieve underlying SQLite C-API metadata (OriginName, TableName, DatabaseName, and DeclType).
    • This feature is exposed via the idiomatic database/sql escape hatch (*sql.Conn).Raw(), avoiding custom statement handles and keeping the standard library workflow intact.
    • See [GitLab merge request #113](https://gitlab.com/cznic/sqlite/-/merge_requests/113), thanks Josh Bleecher Snyder!

  • 2026-04-17 v1.49.0: Upgrade to SQLite 3.53.0.

  • 2026-04-06 v1.48.2:

    • Fix ABI mapping mismatch in the pre-update hook trampoline that caused silent truncation of large 64-bit RowIDs.
    • Ensure the Go trampoline signature correctly aligns with the public sqlite3_preupdate_hook C API, preventing data corruption for high-entropy keys (e.g., Snowflake IDs).
    • See [GitLab merge request #98](https://gitlab.com/cznic/sqlite/-/merge_requests/98), thanks Josh Bleecher Snyder!
    • Fix the memory allocator used in (*conn).Deserialize.
    • Replace tls.Alloc with sqlite3_malloc64 to prevent internal allocator corruption. This ensures the buffer is safely owned by SQLite, which may resize or free it due to the SQLITE_DESERIALIZE_RESIZEABLE and SQLITE_DESERIALIZE_FREEONCLOSE flags.
    • Prevent a memory leak by properly freeing the allocated buffer if fetching the main database name fails before handing ownership to SQLite.
    • See [GitLab merge request #100](https://gitlab.com/cznic/sqlite/-/merge_requests/100), thanks Josh Bleecher Snyder!
    • Fix (*conn).Deserialize to explicitly reject nil or empty byte slices.

... (truncated)

Commits
  • 66b4d20 release v1.52.0, upgrade to SQLite 3.53.2
  • e3f64ec rows: clarify parseFmtIdx mixed-column cost; CHANGELOG.md: document #125
  • 4485793 Merge branch 'perf/cache-parse-time-format' into 'master'
  • 3638d17 rows: cache the parseTime format index per result column
  • 7da793e CHANGELOG.md: document #124
  • 51e6714 Merge branch 'perf/cache-column-decltype' into 'master'
  • 8a6f33c rows: lock down ColumnTypeScanType under the decltype cache
  • f8fb6dd rows: cache the column decltype lookup once per result set
  • b17c0c7 CHANGELOG.md: document #123
  • c80a08f Merge branch 'perf/column-text-zero-copy' into 'master'
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
deps(deps): bump modernc.org/sqlite from 1.46.1 to 1.52.0
e35f013 
Bumps [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) from 1.46.1 to 1.52.0.
- [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/cznic/sqlite/compare/v1.46.1...v1.52.0)

---
updated-dependencies:
- dependency-name: modernc.org/sqlite
  dependency-version: 1.52.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github

dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, go. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot Bot mentioned this pull request Jun 8, 2026
Closed
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

2026/06/08 03:44:25 warning: failed to create SQLite directory /custom/path: mkdir /custom: permission denied (factory will handle this)
2026/06/08 03:44:25 Initializing in-memory storage
2026/06/08 03:44:25 Initializing SQLite storage at /tmp/TestNewStorage1132083137/001/factory-test.db
2026/06/08 03:44:25 Warmed cache with 0 thoughts
2026/06/08 03:44:25 SQLite storage initialized successfully at /tmp/TestNewStorage1132083137/001/factory-test.db
2026/06/08 03:44:25 SUCCESS: SQLite storage initialized - type is *storage.SQLiteStorage
2026/06/08 03:44:25 Initializing SQLite storage at /invalid/�/path/test.db
2026/06/08 03:44:25 ERROR: SQLite initialization FAILED: failed to ping database: unable to open database file (14)
2026/06/08 03:44:25 Initializing SQLite storage at 
2026/06/08 03:44:25 ERROR: SQLite initialization FAILED: database path cannot be empty
2026/06/08 03:44:25 Initializing SQLite storage at /tmp/TestNewStorageFromEnv4275761675/001/default-test.db
2026/06/08 03:44:25 Warmed cache with 0 thoughts
2026/06/08 03:44:25 SQLite storage initialized successfully at /tmp/TestNewStorageFromEnv4275761675/001/default-test.db
2026/06/08 03:44:25 SUCCESS: SQLite storage initialized - type is *storage.SQLiteStorage
2026/06/08 03:44:25 Initializing in-memory storage
2026/06/08 03:44:25 Initializing SQLite storage at /tmp/TestNewStorageFromEnv4275761675/001/env-test.db
2026/06/08 03:44:25 Warmed cache with 0 thoughts
2026/06/08 03:44:25 SQLite storage initialized successfully at /tmp/TestNewStorageFromEnv4275761675/001/env-test.db
2026/06/08 03:44:25 SUCCESS: SQLite storage initialized - type is *storage.SQLiteStorage
2026/06/08 03:44:25 Warmed cache with 0 thoughts
2026/06/08 03:44:25 SQLite storage initialized successfully at /tmp/TestCloseStorage2460787582/001/close-test.db
2026/06/08 03:44:25 Initializing SQLite storage at 
2026/06/08 03:44:25 ERROR: SQLite initialization FAILED: database path cannot be empty
2026/06/08 03:44:25 Initializing SQLite storage at /invalid/�/path/test.db
2026/06/08 03:44:25 ERROR: SQLite initialization FAILED: failed to ping database: unable to open database file (14)
2026/06/08 03:44:25 Initializing SQLite storage at /tmp/TestFactoryCreatesDirectoryForSQLite4077264560/001/subdir/test.db
2026/06/08 03:44:25 ERROR: SQLite initialization FAILED: failed to ping database: unable to open database file (14)
2026/06/08 03:44:25 Initializing SQLite storage at /tmp/TestFactorySQLiteWithCustomTimeout2374165605/001/timeout-test.db
2026/06/08 03:44:25 Warmed cache with 0 thoughts
2026/06/08 03:44:25 SQLite storage initialized successfully at /tmp/TestFactorySQLiteWithCustomTimeout2374165605/001/timeout-test.db
2026/06/08 03:44:25 SUCCESS: SQLite storage initialized - type is *storage.SQLiteStorage
2026/06/08 03:44:25 Warmed cache with 0 thoughts
2026/06/08 03:44:25 SQLite storage initialized successfully at /tmp/TestFactorySQLiteStorageIsCloser2465555605/001/closer-test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at test_rl.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at test_rl_all.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at test_rl_outcome.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at test_rl_increment.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at test_rl_perf.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestNewSQLiteStorage3457392068/001/new.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestNewSQLiteStorage3457392068/002/existing.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestNewSQLiteStorage3457392068/002/existing.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteStoreAndGetThought462675192/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteGetThought3181570709/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLitePersistenceAcrossRestarts1235036053/001/persistence.db
2026/06/08 03:44:26 Warmed cache with 1 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLitePersistenceAcrossRestarts1235036053/001/persistence.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteCacheConsistency1876202327/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteStoreBranch445615933/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteBranchWithAssociations2762962400/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteFullTextSearch2168227449/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteStoreInsight528387819/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteStoreValidation253882220/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteStoreRelationship3686421454/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteUpdateBranchPriority2831794248/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteUpdateBranchConfidence3263385631/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteConcurrentAccess4226553336/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteSchemaInitialization1935437018/001/schema.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLitePreparedStatements2104642908/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteClose820964211/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteErrorHandling1231939111/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteWarmCache862513047/001/warmcache.db
2026/06/08 03:44:26 Warmed cache with 10 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteWarmCache862513047/001/warmcache.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteUpdateThought3546876488/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteListBranches1921887633/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteActiveBranch469403814/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteSearchPagination1274767070/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteDatabaseLocked3344870683/001/locked.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteDatabaseLocked3344870683/001/locked.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteScanThought3925965672/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteScanInsight388455982/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteMetrics4156231794/001/test.db
2026/06/08 03:44:26 Warmed cache with 0 thoughts
2026/06/08 03:44:26 SQLite storage initialized successfully at /tmp/TestSQLiteRecentBranches1884510424/001/test.db
goos: linux
goarch: amd64
pkg: unified-thinking/internal/storage
cpu: AMD EPYC 9V74 80-Core Processor                
BenchmarkSearchThoughts_SmallResultSet-4   	  243624	     15059 ns/op	   17360 B/op	      55 allocs/op
BenchmarkSearchThoughts_LargeResultSet-4   	   16135	    220426 ns/op	  233465 B/op	     428 allocs/op
BenchmarkIndexThoughtContent-4             	  108067	    308018 ns/op	    3719 B/op	      11 allocs/op
BenchmarkCopyThought/Original-4            	 1297057	      2749 ns/op	    1240 B/op	      32 allocs/op
BenchmarkCopyThought/Optimized-4           	21775208	       165.6 ns/op	      48 B/op	       1 allocs/op
BenchmarkLRUEviction-4                     	2026/06/08 03:46:36 Evicted 10000 LRU index entries (index size now: 90000)
2026/06/08 03:47:21 Evicted 10000 LRU index entries (index size now: 90000)
    2677	   1332130 ns/op	    2045 B/op	      10 allocs/op
BenchmarkSearchWithMapConversion/Small-10-4         	   46947	     73845 ns/op	   91984 B/op	      41 allocs/op
BenchmarkSearchWithMapConversion/Medium-50-4        	   45778	     79018 ns/op	  101280 B/op	     121 allocs/op
BenchmarkSearchWithMapConversion/Large-200-4        	   36654	     98230 ns/op	  136256 B/op	     421 allocs/op
BenchmarkConcurrentReads-4                          	fatal error: concurrent map writes

goroutine 551 [running]:
internal/runtime/maps.fatal({0x90842a?, 0x0?})
	/opt/hostedtoolcache/go/1.25.10/x64/src/runtime/panic.go:1046 +0x18
unified-thinking/internal/storage.(*MemoryStorage).searchByIndex(0xc000090000, {0x901678?, 0xc0000223a8?}, {0x901bbc, 0x6})
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:559 +0x277
unified-thinking/internal/storage.(*MemoryStorage).SearchThoughts(0xc000090000, {0x901678?, 0x3?}, {0x901bbc?, 0x41ab65?}, 0x20?, 0x0)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:461 +0x1ca
unified-thinking/internal/storage.BenchmarkConcurrentReads.func1(0xc000284000)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory_bench_test.go:186 +0x4f
testing.(*B).RunParallel.func1()
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:977 +0xb8
created by testing.(*B).RunParallel in goroutine 566
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:970 +0x113

goroutine 1 [chan receive]:
testing.(*B).doBench(0xc000134848)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:297 +0x78
testing.(*benchState).processBench(0xc000371608, 0x20?)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:761 +0x3cb
testing.(*B).run(0xc000134848?)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:288 +0x5b
testing.(*B).Run(0xc000134588, {0x909823?, 0xc00013bae8?}, 0x92f558)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:863 +0x4e5
testing.runBenchmarks.func1(0xc000134588)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:721 +0x3e
testing.(*B).runN(0xc000134588, 0x1)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:219 +0x190
testing.runBenchmarks({0x90ea87, 0x21}, 0x0?, {0xcd7700, 0x8, 0xc000073b00?})
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:730 +0x5f1
testing.(*M).Run(0xc00014a5a0)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/testing.go:2353 +0x996
main.main()
	_testmain.go:267 +0x9b

goroutine 566 [sync.WaitGroup.Wait]:
sync.runtime_SemacquireWaitGroup(0xc0000f0090?, 0x0?)
	/opt/hostedtoolcache/go/1.25.10/x64/src/runtime/sema.go:114 +0x2e
sync.(*WaitGroup).Wait(0xc0002151d0)
	/opt/hostedtoolcache/go/1.25.10/x64/src/sync/waitgroup.go:206 +0x85
testing.(*B).RunParallel(0xc000134848, 0xc00002e010)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:980 +0x1af
unified-thinking/internal/storage.BenchmarkConcurrentReads(0xc000134848)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory_bench_test.go:184 +0x3ea
testing.(*B).runN(0xc000134848, 0x64)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:219 +0x190
testing.(*B).launch(0xc000134848)
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:354 +0x1bc
created by testing.(*B).doBench in goroutine 1
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:296 +0x65

goroutine 552 [runnable]:
unified-thinking/internal/storage.(*MemoryStorage).SearchThoughts(0xc000090000, {0x901678?, 0x3?}, {0x901bbc?, 0x41ab65?}, 0x20?, 0x0)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:470 +0x250
unified-thinking/internal/storage.BenchmarkConcurrentReads.func1(0xc000280000)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory_bench_test.go:186 +0x4f
testing.(*B).RunParallel.func1()
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:977 +0xb8
created by testing.(*B).RunParallel in goroutine 566
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:970 +0x113

goroutine 550 [runnable]:
unified-thinking/internal/storage.(*MemoryStorage).searchByIndex(0xc000090000, {0x901678?, 0x4?}, {0x901bbc, 0x6})
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:590 +0x4fc
unified-thinking/internal/storage.(*MemoryStorage).SearchThoughts(0xc000090000, {0x901678?, 0xc000134848?}, {0x901bbc?, 0x41ab65?}, 0x20?, 0x0)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:461 +0x1ca
unified-thinking/internal/storage.BenchmarkConcurrentReads.func1(0xc000300000)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory_bench_test.go:186 +0x4f
testing.(*B).RunParallel.func1()
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:977 +0xb8
created by testing.(*B).RunParallel in goroutine 566
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:970 +0x113

goroutine 553 [runnable]:
unified-thinking/internal/storage.(*MemoryStorage).searchByIndex(0xc000090000, {0x901678?, 0xc0000223a8?}, {0x901bbc, 0x6})
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:579 +0x636
unified-thinking/internal/storage.(*MemoryStorage).SearchThoughts(0xc000090000, {0x901678?, 0x3?}, {0x901bbc?, 0x41ab65?}, 0x20?, 0x0)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory.go:461 +0x1ca
unified-thinking/internal/storage.BenchmarkConcurrentReads.func1(0xc00025cb80)
	/home/runner/work/unified-thinking/unified-thinking/internal/storage/memory_bench_test.go:186 +0x4f
testing.(*B).RunParallel.func1()
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:977 +0xb8
created by testing.(*B).RunParallel in goroutine 566
	/opt/hostedtoolcache/go/1.25.10/x64/src/testing/benchmark.go:970 +0x113
exit status 2
FAIL	unified-thinking/internal/storage	192.398s
FAIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants