fix(release): drop Windows quant-server.exe + add workflow_dispatch#45
Merged
fix(release): drop Windows quant-server.exe + add workflow_dispatch#45
Conversation
The Windows build job tried to copy quant-server.exe which doesn't exist — CMakeLists.txt:311 has `if(TQ_BUILD_SERVER AND NOT MSVC)` so quant-server is intentionally not built on MSVC (uses POSIX sockets). Changes: 1. Windows build no longer passes -DTQ_BUILD_SERVER=ON (no-op anyway) and the package step no longer references quant-server.exe. 2. Added workflow_dispatch trigger so the release workflow can be re-run for an existing tag without re-tagging. 3. Each checkout step now respects github.event.inputs.tag for workflow_dispatch runs. 4. softprops/action-gh-release uses explicit tag_name from input. This unblocks the v0.12.0 GitHub Release (PyPI v0.12.0 already published successfully). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows build was failing because it tried to copy `quant-server.exe` which CMakeLists.txt explicitly does not build on MSVC (`if(TQ_BUILD_SERVER AND NOT MSVC)` — uses POSIX sockets).
Changes:
This unblocks v0.12.0 GitHub Release. PyPI v0.12.0 is already published.
🤖 Generated with Claude Code