-
Notifications
You must be signed in to change notification settings - Fork 48
Fix theme updating when VS Code auto theme detection is on #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add notification system to send actual theme kind from VS Code to LSP - Track active color theme kind in LSP ConfigurationManager - Send theme notifications on startup and when theme changes - Use actual theme kind instead of parsing theme name Co-authored-by: kv9898 <105025148+kv9898@users.noreply.github.com>
- Add explicit check for 'Dark' in theme name fallback - Only fire configuration change event if theme actually changed Co-authored-by: kv9898 <105025148+kv9898@users.noreply.github.com>
- Add validation for theme kind parameter in notification handler - Document HighContrast theme handling (treated as dark) - Prevent fallback detection from overriding explicit theme notifications - Add flag to track whether theme was explicitly set Co-authored-by: kv9898 <105025148+kv9898@users.noreply.github.com>
Thanks! I understand that Quarto is highly modularized and communication between parts can be tricky (and debugging quarto is definitely not easy from my experience). |
|
@vezwork Happy New Year! Any updates? |
|
Tried this out and it does seem to fix the issue. I looked into the solution and it does seem that:
As such, this was pretty close to a minimal solution. I cleaned it up a bit. It is also a necessary fix in other ways because our colorTheme config in the LSP did not accurately represent the current theme previously, it only represented the user's |
juliasilge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Fixes #861
I admit the fix is a bit ugly and I wish better solutions are possible.