Skip to content

fix(graph): add decodeURIComponent for non-ASCII page URLs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
posebear1990 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(graph): add decodeURIComponent for non-ASCII page URLs #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0deb5f6
fix(graph): add decodeURIComponent for non-ASCII page URLs and filter…
posebear1990 Jul 27, 2026
f59175d
refactor(graph): extract safeDecodeURIComponent helper for DRY URL de…
posebear1990 Jul 27, 2026
c35c931
refactor(graph): import safeDecodeURIComponent directly from util/lang
posebear1990 Jul 27, 2026
a54e9b1
fix(graph): focus PR strictly on decodeURIComponent for non-ASCII pag…
posebear1990 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/components/scripts/graph.inline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
simplifySlug,
resolveBasePath,
} from "@quartz-community/utils";
import { safeDecodeURIComponent } from "../../util/lang";

(function () {
function getSlugFromUrl() {
Expand Down Expand Up @@ -87,7 +88,7 @@ import {
}

async function renderGraph(graph, fullSlug, renderGeneration) {
var slug = simplifySlug(fullSlug);
var slug = safeDecodeURIComponent(simplifySlug(fullSlug));
if (slug === "") slug = "index";
var visited = getVisited();
removeAllChildren(graph);
Expand Down Expand Up @@ -117,7 +118,7 @@ import {
var dataRaw = await fetchData;
data = new Map();
for (var key in dataRaw) {
data.set(simplifySlug(key), dataRaw[key]);
data.set(safeDecodeURIComponent(simplifySlug(key)), dataRaw[key]);
}
} catch (err) {
console.error("[Graph] Error loading data:", err);
Expand All @@ -134,7 +135,7 @@ import {
data.forEach(function (details, source) {
var outgoing = details.links || [];
for (var i = 0; i < outgoing.length; i++) {
var dest = simplifySlug(outgoing[i]);
var dest = safeDecodeURIComponent(simplifySlug(outgoing[i]));
if (validLinks.has(dest)) {
links.push({ source: source, target: dest });
}
Expand All @@ -145,7 +146,7 @@ import {
for (var i = 0; i < tags.length; i++) {
var tag = tags[i];
if (removeTags.indexOf(tag) === -1) {
var tagSlug = simplifySlug("tags/" + tag);
var tagSlug = safeDecodeURIComponent(simplifySlug("tags/" + tag));
if (allTags.indexOf(tagSlug) === -1) {
allTags.push(tagSlug);
}
Expand Down Expand Up @@ -191,7 +192,7 @@ import {
var nodeMap = new Map();
neighbourhood.forEach(function (url) {
var isTag = url.startsWith("tags/");
var text = isTag ? "#" + url.substring(5) : data.get(url)?.title || url;
var text = isTag ? "#" + url.substring(5) : data.get(url)?.title || safeDecodeURIComponent(url);
var nodeTags = isTag ? [] : data.get(url)?.tags || [];
var node = {
id: url,
Expand Down
9 changes: 9 additions & 0 deletions src/util/lang.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
export { classNames } from "@quartz-community/utils/lang";

export function safeDecodeURIComponent(str: string): string {
try {
return decodeURIComponent(str);
} catch {
return str;
}
}