chore: final post-Rust cleanup#10
Merged
Merged
Conversation
Removes leftover scaffolding and stale references that survived the Starlark migration and earlier WORKSPACE-example removal: Deleted: - tools/BUILD.bazel (empty) - tools/config_setting/ (older duplicate of tools/platforms/, no consumers) - playwright/private/cli/src/test/ (Rust unit-test fixtures) - docs/starlark_no_rust_spike.md (migration write-up — work is done) - renovate.json (dependabot.yml now covers github-actions, bazel, npm) Edited: - .gitignore: drop /target and the "Added by cargo" marker - .bazelignore: drop target/ - .github/dependabot.yml: drop two /examples/workspace entries (the example directory was removed in PR #7) - README.md: drop links to docs/extensions.md / repositories.md / integrity_map.md — those files exist only in the released doc tarball, not in source - CONTRIBUTING.md: drop the "bazel run //:gazelle" instruction — no gazelle target is configured in this repo Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The third in a series cleaning up after the Rust→Starlark spike (#3), the WORKSPACE-example removal (#7), and the toolchain drops (#8/#9). This sweeps the remaining vestigial files and stale doc/config references.
Deletions
tools/BUILD.bazel— empty 0-byte filetools/config_setting/— older duplicate oftools/platforms/; no live consumersplaywright/private/cli/src/test/—browsers.jsonfixture + emptyBUILD.bazelfrom the deleted Rust unit testsdocs/starlark_no_rust_spike.md— the migration design doc; migration shipped in Refactor: remove Rust CLI and implement Playwright repo generation in Starlark #3, history available in the PR/commitrenovate.json— Dependabot now covers github-actions, bazel modules, and npm; running two bots would open duplicate PRsEdits
.gitignore— drop/targetand the# Added by cargoline.bazelignore— droptarget/.github/dependabot.yml— drop the two/examples/workspaceentries (the example directory was removed in chore: remove legacy WORKSPACE example #7)README.md— drop the Documentation section pointing atdocs/extensions.md/docs/repositories.md/docs/integrity_map.md; those files are generated only into the released docs tarball byrelease_prep.sh, not committed to sourceCONTRIBUTING.md— drop thebazel run //:gazelleinstruction; no gazelle target is configured in this repoIntentionally NOT changed (deferred to your call)
WORKSPACE.bazel(empty marker — still valid under bzlmod on Bazel 9 but harmless).github/workflows/buildifier.yaml.disabled(disabled workflow — enable or delete)tools/version.bzl(orphanedVERSION/IS_PRERELEASE— depends on a missing.gitattributesexport-subst hook)examples/rules_js/MODULE.bazeldeprecatedintegrity_mapattr usageTest plan
bazelisk build //...passesexamples/rules_jstests pass (none of the removed paths are referenced)🤖 Generated with Claude Code