Remove the --minimal flag from skill office - #240
Merged
Conversation
The flag (and its -Minimal PowerShell translation) is no longer advertised or accepted — passing it now fails with "unknown option". The setup scripts drop their side of the flag in codev-scripts. README's passthrough sentence now documents --skip-verify and --force-skills, which was missing since the #236 passthrough landed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops
--minimalfromcodevhub skill office: usage string,OfficeArgs, parsing, the uninstall-mixture guard,installerArgs(both the GNU--minimaland PowerShell-Minimaltranslations), thecodevhub helpentry, and the README. Passing--minimalnow exits withunknown option: --minimal.The README passthrough sentence now names
--skip-verifyand--force-skills(the latter was undocumented there since #236).Companion change: the setup scripts drop their
--minimal/-Minimalhandling in codev-scripts, and the landing-page docs stopped advertising the flag in quickbeard/codev-landing-page#85.Test plan
npm run typechecknpm test— 76 files, 1378 passed / 2 skipped🤖 Generated with Claude Code