Conversation
…alidate-qml-in-py
KitsuneRal
left a comment
KitsuneRal
left a comment
There was a problem hiding this comment.
Overall it looks good, aside from a couple of questions below.
| def __init__(self, *args, **kwargs) -> None: | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| QtQml.qmlRegisterUncreatableType(Quotient.EventStatus, 'Quotient', 1, 0, 'EventStatus', 'EventStatus is not a creatable type') |
There was a problem hiding this comment.
I suppose this doesn't work now that EventStatus is a namespace (since yesterday in master - sorry for taking time to resolve this)?
| # Resource object code (Python 3) | ||
| # Created by: object code | ||
| # Created by: The Resource Compiler for Qt version 6.1.1 | ||
| # WARNING! All changes made in this file will be lost! |
There was a problem hiding this comment.
Should this file be under version control or does the build system recreate it every time the bindings are generated?
There was a problem hiding this comment.
As we decide. Actually, it's not generated in build system, but it's easy to do so. Should I? It's autogenerated python wrapper for resources, so it makes sense, yes.
There was a problem hiding this comment.
As discussed, let's make generation of this file a part of the build sequence; but please double-check with PySide people what they think about it.
…alidate-qml-in-py
…has not meta data and cannot be registered as qml type
2 participants
Closes #24