patch to fix Azure OAuth Code flow when using default (localhost) redirect URL#829
Open
pedrobtz wants to merge 1 commit intor-lib:mainfrom
Open
patch to fix Azure OAuth Code flow when using default (localhost) redirect URL#829pedrobtz wants to merge 1 commit intor-lib:mainfrom
pedrobtz wants to merge 1 commit intor-lib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #828
When
oauth_flow_auth_codeuses the default redirect URI fromoauth_redirect_uri()(and it returns "http://localhost/"), the subsequent call tonormalize_redirect_uri()adds a random port, creating a mismatch between the authorization and token requests.possible solution: use
redirect$uriin the second request as well.