Conversation
DavisVaughan
approved these changes
Apr 16, 2026
Comment on lines
+188
to
+194
| // `Rf_findVarInFrame3()` evaluates active bindings via `BINDING_VALUE()` | ||
| // on R < 4.5, so skip `env_find()` to avoid evaluating them twice (#1893) | ||
| if (type != R_ENV_BINDING_TYPE_active) { | ||
| r_obj* value = env_find(env, sym); | ||
| if (r_typeof(value) == R_TYPE_dots) { | ||
| return value; | ||
| } |
Member
There was a problem hiding this comment.
Would it also be better to do a pointer comparison of sym against Rf_install("...") to see if we even need to do the env_find()? Or maybe you can have a DOTSXP in an env even if the name isn't ... so that might not catch every case?
I'm just mildly annoyed from a performance perspective that you have to kind of "get" the thing twice, but i guess its also for R < 4.5 so its probably fine as is i suppose...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1893