-
Notifications
You must be signed in to change notification settings - Fork 307
create_from_github() tweaks
#2186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+19
−3
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
493f804
`create_from_github()` tweaks
hadley 4d36f90
Add missing `repo_path`
hadley 3404cf5
Add news bullet
hadley 7b2911c
Merge branch 'main' into install-deps
hadley 601f742
Apply suggestion from @jennybc
jennybc fe00107
Merge branch 'main' into install-deps
jennybc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,7 @@ Imports: | |
| glue (>= 1.3.0), | ||
| jsonlite, | ||
| lifecycle (>= 1.0.0), | ||
| pak, | ||
| purrr, | ||
| rappdirs, | ||
| rlang (>= 1.1.0), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to put this down in writing: in some workflows for "make this new thing", leaving
.Rprojbehind is still somewhat load-bearing in terms of advertising a project root and there's no Positron equivalent. And it doesn't hurt anything.But we don't have to fret over this here, because, by definition, if you're using
create_from_github(), we're talking about a git repo and that is a strong signal of the project root. And obviously it's nicer to not have a vestigial, unnecessary.Rprojfile.