Feat/pairwise azimuth#97
Merged
Merged
Conversation
This reverts commit a387e00.
edzer
reviewed
Dec 5, 2024
Contributor
Author
|
Hello @edzer - apologies for my delay getting back to this, I have been away from this work for a bit. I just added two sets of tests, one for st_geod_azimuth with a single argument (x) and the other for st_geod_azimuth with two arguments (x, y). Let me know how it looks on your end, I appreciate your help as I'm not totally familiar with everything going on here (eg. memory management with lwgeom_free). Thanks! |
edzer
reviewed
Aug 13, 2025
Member
|
Thanks; there's one comment in the PR to be resolved. |
Contributor
Author
|
Thanks, let me know how that looks on your end! |
Member
|
Thanks! |
Contributor
Author
|
Thank you!! I really appreciate your help with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional pairwise azimuth implementation for
st_geod_azimuth.See #96.
Reprex (updated 2024-12-06)
Created on 2024-12-06 with reprex v2.1.1