Always compile embedded C/C++ code with -fPIC - #63
Merged
Conversation
…p in the shared module. Needed for e.g. ggsql.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes rust packages containing C/C++ code, such as ggsql (which embeds duckdb). I think it makes sense to do this globally, as all code will eventually end up in the package shared module, and the package may not even be aware that it is targeting wasm.
Before: https://github.com/r-universe/cran/actions/runs/30764904729/job/93889416606
After: https://github.com/r-universe/cran/actions/runs/30764904729/job/93913762138
Another exampe:
Before: https://github.com/r-universe/posit-dev/actions/runs/31491587902/job/93780103387
After: https://github.com/r-universe/posit-dev/actions/runs/31491587902