Add optional downloadTimeout to bound package/file downloads - #616
Open
Forevener wants to merge 1 commit into
Open
Add optional downloadTimeout to bound package/file downloads#616Forevener wants to merge 1 commit into
Forevener wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadFileContent issues a synchronous XMLHttpRequest with no timeout, so a repository that's unreachable in a way that leaves the connection pending (accepted-but-no-response, or a black-holed route) parks the worker thread inside send() indefinitely — R can't service interrupts while blocked there, so webr::install() never returns and the session wedges. R's options(timeout=) doesn't reach this path. This adds an optional downloadTimeout (ms) so consumers can bound these requests; on expiry the existing catch turns it into a clean download failure and the installer can fall through to the next repo. Default 0 preserves current behavior (no timeout) — fully non-breaking. timeout on a sync XHR is permitted in a Worker/Node context (only disallowed when the global is a Window). Could be related to #235.