Repository navigation
Record the skip-back amount for skip-back in playback history - #1205
Merged
Merged
Conversation
PlaybackHistoryForwardingPlayer recorded a skip back as moving back by the skip-forward time, so the history showed the wrong target position whenever the two times differ.
Generated by 🚫 Danger Kotlin against 2fc8fe1 |
Collaborator
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing #607. On Android, playback history recorded every skip back as moving back by the skip-forward time, so the recorded target position was wrong whenever the two skip times differ (for example, forward 30s and back 10s).
What changed
PlaybackHistoryForwardingPlayer.seekBack()records the back amount (backwardTimeMs) instead of the forward amount.Verification
./scripts/ktlint --checkpasses and:infra:audioplayer:impl:compileAndroidMaincompiles.🤖 Generated with Claude Code