Skip to content

Apply skip-time changes to a running player - #1206

Merged
r0adkll merged 1 commit into
mainfrom
fix/apply-skip-times-live
Oct 6, 2026
Merged

r0adkll merged 1 commit into
mainfrom
fix/apply-skip-times-live

Conversation

@r0adkll

@r0adkll r0adkll commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Found while testing #607. On Android, changing the skip forward or back time in Settings → Playback updated the player's button labels straight away, but the actual skips kept the old amounts until the app restarted. ExoPlayer took its seek increments once, from the builder, when the player was created.

What changed

  • ExoPlayerAudioPlayer collects observeForwardTimeMs() and observeBackwardTimeMs() in its main-thread scope, and pushes changes into ExoPlayer's runtime setSeekForwardIncrementMs / setSeekBackIncrementMs (added in Media3 1.11).
    • That covers the in-app buttons, the media notification and other media-session controls.
    • Desktop and iOS already read the skip times on every skip.
  • A changelog entry under Fixed.

Verification

  • ./scripts/ktlint --check passes, :app:android:compileAlphaDebugKotlin compiles, and :infra:audioplayer:impl:jvmTest passes.
  • On device: the same change was verified on the emulator in the closed Apply skip-time changes to a running player #1198, in one app session without restarting. Each change took effect on the next skip, whether from the in-app buttons, cmd media_session dispatch fast-forward / rewind, or the notification buttons:
Skip times (forward / back) Result
30s / 10s (unchanged) +30s / −10s
changed to 5s / 30s +5s / −30s
changed to 10s / 5s +10s / −5s

🤖 Generated with Claude Code

ExoPlayer took its seek increments once, from the builder, when the player
was created, so changing the forward or back skip in Settings only took
effect after the app restarted. Follow the settings and push changes into
ExoPlayer's runtime increment setters.
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Messages
📖 This PR has been checked by Danger

Generated by 🚫 Danger Kotlin against d155d34

@Rotom-Bot

Copy link
Copy Markdown
Collaborator

Code Coverage

Total Project Coverage 23.49% ❌

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Android APK @ d25fea3

@r0adkll
r0adkll merged commit 4c5318e into main Oct 6, 2026
7 checks passed
@r0adkll
r0adkll deleted the fix/apply-skip-times-live branch October 6, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants