Conversation
Every Client method issues a requests call with no timeout, so a connection that dies mid-request (proxy restart, network partition) blocks the calling thread forever instead of raising. Add a timeout applied to all requests, defaulting to 10 seconds and overridable via the constructor.
bharat
marked this pull request as ready for review
August 15, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes a failure mode I hit in production this week: every
Clientmethod issues arequestscall with no timeout, so a connection that dies mid-request blocks the calling thread forever. In my case a reverse proxy restarted while Home Assistant's alarm integration was mid-poll, and the polling thread hung silently for 2.5 hours until a full restart reaped it.What this does
timeoutapplied to every request inconcord232/client/client.py, defaulting to 10 seconds and overridable via the constructor (Client(url, timeout=...)). A dead connection now raisesrequests.exceptions.Timeoutinstead of hanging.Existing callers are unaffected: the constructor signature gains only a defaulted parameter, and 10 seconds is comfortably above normal response times for this API (my panel answers in tens of milliseconds).
The full suite passes (73 tests), and the two changed files are clean under ruff, black, and isort. Happy to adjust the default or the shape of the override if you would like it done differently.