Add multi-architecture Docker image build support#3
Merged
Conversation
- Use matrix strategy to build on both x86_64 and arm64 runners - Push architecture-specific images with -amd64 and -arm64 tags - Create Docker manifest combining both architectures - Support both commit SHA and latest tags as multi-arch manifests
- Remove push-only restriction from manifest job so PRs also get multi-arch images - Add new comment job that posts Docker image tags on PRs - Use peter-evans/find-comment and create-or-update-comment to update existing comment instead of spamming - Include ready-to-use docker pull and docker run commands in comment
🐳 Docker Image ReadyMulti-arch image (recommended): docker pull wholelottahoopla/mcp-exec:000f570cec6ee8b2f37f1a421dcf21e3b9c2bf32Run with HTTP server: docker run -d -p 8080:8080 -v /var/lib/mcp-exec:/logs \
wholelottahoopla/mcp-exec:000f570cec6ee8b2f37f1a421dcf21e3b9c2bf32 \
--http-port 8080 --bind-address 0.0.0.0 --directory-path /logsArchitecture-specific tagsAMD64: docker pull wholelottahoopla/mcp-exec:000f570cec6ee8b2f37f1a421dcf21e3b9c2bf32-amd64ARM64: docker pull wholelottahoopla/mcp-exec:000f570cec6ee8b2f37f1a421dcf21e3b9c2bf32-arm64Built from commit 000f570 |
Cmd gets replaced when passing arguments to docker run, while Entrypoint gets arguments appended. This allows users to pass CLI flags like --http-port directly to the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Docker build and push workflow to support building and publishing multi-architecture (amd64 and arm64) Docker images with proper manifest management.
Key Changes
dockerjob is now abuildjob that runs on multiple architectures (amd64 onubuntu-latestand arm64 onubuntu-24.04-arm) using GitHub Actions matrix strategysha-amd64,sha-arm64) to distinguish per-architecture buildsmanifestjob that runs after all architecture builds complete to create and push multi-architecture manifestslatestmanifest when pushing to main/master branchesImplementation Details
buildjob uses a matrix with three variables per architecture:arch,runner, andplatformmanifestjob depends on thebuildjob completing successfully vianeeds: build