Make workflows ActiveJob-compatible - #20
Merged
Merged
Conversation
zewelor
commented
Mar 21, 2026
zewelor
commented
Contributor
- Have R3x::Workflow::Base inherit ApplicationJob and include Continuable
- Execute workflows with perform(trigger_key, trigger_payload:) calling run(ctx)
- Change enqueuing to call workflow_class.perform_later / perform_now
- Generate recurring tasks using workflow class name and queue_name
- Add guard to prevent overriding #perform; require #run(ctx) in subclasses
- Update ChangeDetectionJob, RunWorkflowJob, ManualRunner and tests to match
zewelor
force-pushed
the
poc_activejob_continuation
branch
from
March 27, 2026 12:35
d274be6 to
6fe3616
Compare
- Add planning docs for Gmail output, Google Sheets client, and OAuth2 - Provide API sketches, ClientProxy integration, env/vault naming, flows - Recommend gems and describe modes, error handling, and usage examples - Add a one-line todo about implementing ActiveJob Continuation for workflows
- Have R3x::Workflow::Base inherit ApplicationJob and include Continuable - Execute workflows with perform(trigger_key, trigger_payload:) calling run(ctx) - Change enqueuing to call workflow_class.perform_later / perform_now - Generate recurring tasks using workflow class name and queue_name - Add guard to prevent overriding #perform; require #run(ctx) in subclasses - Update ChangeDetectionJob, RunWorkflowJob, ManualRunner and tests to match
zewelor
force-pushed
the
poc_activejob_continuation
branch
from
March 27, 2026 12:46
6fe3616 to
ef732b4
Compare
- Remove draft plan file `docs/todo/plan-gmail-output.md` - Remove stale design notes for Gmail output implementation - Reduce noise in `docs/todo`; plan is implemented or relocated
- Remove stale TODO plan docs for Google integrations - Delete `docs/todo/plan-google-oauth2.md` - Delete `docs/todo/plan-google-sheets-client.md` - Tidy docs by removing outdated planning notes
- Bump action_text-trix, bigdecimal, and parser to patch versions - Update checksums in `Gemfile.lock` after dependency resolution - Result of running `bundle update` to refresh transitive gems - No application code changes; only lockfile version updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.