Upgrade gen_batch_server to v0.10.0#213
Merged
Merged
Conversation
And update osiris_writer to use mailbox flushing.
There was a problem hiding this comment.
Pull request overview
Updates this Erlang project’s batching server dependency and adjusts osiris_writer startup options to take advantage of the newer gen_batch_server termination behavior (mailbox flushing).
Changes:
- Bump
gen_batch_serverdependency from0.9.1to0.10.0across build tools (rebar3 + erlang.mk). - Configure
osiris_writerto enable mailbox flushing on terminate via gen_batch_server options. - Update
rebar.lockhashes to match the upgraded dependency.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/osiris_writer.erl | Adds gen_batch_server option to flush mailbox on terminate for the writer process. |
| rebar.lock | Updates locked gen_batch_server version and package hashes to 0.10.0. |
| rebar.config | Bumps gen_batch_server dependency version to 0.10.0. |
| Makefile | Bumps erlang.mk hex dependency version for gen_batch_server to 0.10.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And update osiris_writer to use mailbox flushing.