Add node-wide histogram metrics for entry, batch and chunk sizes#215
Draft
the-mikedavis wants to merge 2 commits into
Draft
Add node-wide histogram metrics for entry, batch and chunk sizes#215the-mikedavis wants to merge 2 commits into
the-mikedavis wants to merge 2 commits into
Conversation
This adds histograms like the ones in RabbitMQ for messaging protocol message sizes for simple entries, batches, and chunks. This gives visibility into the message sizes since they aren't captured by the message size histograms in RabbitMQ, and visibility into chunk sizes and rates (which is useful for explaining resource usage).
Contributor
|
I had half a hope we could add historgrams to seshat... |
Collaborator
Author
|
Ah yeah good idea, I bet we can. I'll give it a shot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds histograms like the ones in RabbitMQ for messaging protocol message sizes for simple entries, batches, and chunks. This gives visibility into the message sizes since they aren't captured by the message size histograms in RabbitMQ, and visibility into chunk sizes and rates (which is useful for explaining resource usage).
This is another look at rabbitmq/rabbitmq-server#16220, moving the metrics into Osiris.